Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp7730243rwl; Tue, 10 Jan 2023 04:50:45 -0800 (PST) X-Google-Smtp-Source: AMrXdXvDgQFasTny1bhc5Jt77I2RQ6CG/aP59TOxlCM0qgn8iOai/68gdsqRHCrVr9g9YvUMwTyN X-Received: by 2002:a17:907:6d26:b0:857:b916:94c1 with SMTP id sa38-20020a1709076d2600b00857b91694c1mr2624804ejc.61.1673355045323; Tue, 10 Jan 2023 04:50:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673355045; cv=none; d=google.com; s=arc-20160816; b=x9eZEXNQhkCDLkVaxApx4WK5z/8heyDJyxBH31ntjax8xVT3m/iVjqVaheEGLRtBow +y4q1UksNH1Qci2CPylAItdSC0re09ar0p65sjq9l9CvZTtld5LUtGI5Lbj9g0BeaBFU iyoW6lAWNdT27dhZzSusQQ+fs7hjkMIy8zlT9pt2rzA2F1TSYYhckZepmdBvuw/AhkDC I5nyGh2h+9T2PAhNbF42WaxFfmYptpG2KN1smdLjSSgTI2W4gp29DXbPseIY/pcw9146 0oRzzVAclXAUb0SobQ0a8qR47GMTEomEaZA8bq9f7PhH6fHrIQjRnb+cXsnBuNcNyk2m KIrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=9MUKgd25aphukaT852AKd3FIc+ualJpdf/WpZbnVUmY=; b=MO4/chYrogG6SrN6O717BQCDLSAVukSihrK82xALTsPh89Oz5cDkJns30mGqTIxBge neSq4Qvr7hh4eXt4WkpwL4LwLzCPdnHQc9/CjTdNsnK6g7Hx5EG+qgZkPfXzjRuUbr7p M6Qdfcs37isgMS2ybHrPOI64F/Fq5p9tw/P1URV2ruKJu+H3xDfBB/ZpLbstTZBPtFsj FjDybO8FANBtWJPWc39Jg3DTOQXb6c9i64jirq5tKLla8jBr2wuo/BzTGO007qtx+64g FSCaBxlWgFlH2nE5SgwL4nqLtYOtXg5sLBzol+QD16fyeoDgs6BCGlzLoLtfV3oeYo6k biZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=sRwm0dYf; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ds20-20020a170907725400b007fed8db38a8si12582867ejc.114.2023.01.10.04.50.28; Tue, 10 Jan 2023 04:50:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=sRwm0dYf; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232392AbjAJMl1 (ORCPT + 65 others); Tue, 10 Jan 2023 07:41:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231241AbjAJMlJ (ORCPT ); Tue, 10 Jan 2023 07:41:09 -0500 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 726F216483 for ; Tue, 10 Jan 2023 04:41:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=9MUKgd25aphukaT852AKd3FIc+ualJpdf/WpZbnVUmY=; t=1673354466; x=1674564066; b=sRwm0dYfuWPAQsZIOh4o4rBYqszfl8mMtKi0ZkjGnHr5GP6 wGnz9EhbKhUlCn3zef6Bl8DQ0mj7Udf7oqGN/A0HDO/sAeqmcy5/yAgH5mEg5jiTIFDwUPFK7RVdT 0sRpZ2ZSt9KnhtqoZDfeNjQ2YG82IHML2bwOwVuDRbv5gFeKbsjQIEBcbboKNu6JOeLcgwL2ZHRy4 8xvcDypLCBUBKU0TdJ95TzYtfjqPX9V7piRFkP7vpEYr8t0jumhJ1ndCxJnyTfprWP7S3iD1DEtbJ Nw+6LecOsPAnqIUmSoNfanqe9zveNZQW2cmyHG5Vtv8VOlS8/mzyBhXEdCybQxfQ==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1pFDw8-00FEEi-1N; Tue, 10 Jan 2023 13:41:04 +0100 Message-ID: Subject: Re: [PATCH] wifi: cfg80211: Deduplicate certificate loading From: Johannes Berg To: Lukas Wunner Cc: linux-wireless@vger.kernel.org, David Howells Date: Tue, 10 Jan 2023 13:41:03 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sun, 2023-01-08 at 18:08 +0100, Lukas Wunner wrote: > load_keys_from_buffer() in net/wireless/reg.c duplicates > x509_load_certificate_list() in crypto/asymmetric_keys/x509_loader.c > for no apparent reason. >=20 Well, unless I'm messing up the git blame/history search, it didn't exist as a standalone function when the reg.c code was written :) johannes