Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <65d136e7e83eac38efc10998cc03be58077169c3.camel@sipsolutions.net>
Subject: Re: [RFC v2 2/6] mac80211: add tx-power annotation in control path
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Jonas Jelonek <jelonek.jonas@gmail.com>,
        linux-wireless@vger.kernel.org
Cc:     nbd@nbd.name, Thomas Huehn <thomas.huehn@hs-nordhausen.de>
Date:   Thu, 12 Jan 2023 11:31:19 +0100
In-Reply-To: <20220920104032.496697-3-jelonek.jonas@gmail.com>
References: <20220920104032.496697-1-jelonek.jonas@gmail.com>
         <20220920104032.496697-3-jelonek.jonas@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-09-20 at 12:40 +0200, Jonas Jelonek wrote:
>=20
>   * @rate_idx The actual used rate.
>   * @try_count How often the rate was tried.
> - * @tx_power_idx An idx into the ieee80211_hw->tx_power_levels list of t=
he
> - * 	corresponding wifi hardware. The idx shall point to the power level
> - * 	that was used when sending the packet.
> + * @tx_power_idx An idx into the the tx-power set described by
> + * 	ieee80211_hw->txpower_ranges for the corresponding wifi hardware.
> + * 	The idx shall point to the tx-power level that was used when sending
> + * 	the packet at this rate. A negative value is considered as 'invalid'
> + * 	or 'no power level reported by the driver'.

maybe fix the kernel-doc (at least for this entry) while at it and add
the missing colon.

johannes