Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b5ad26c3-fa10-b056-d79d-8bebb8795a90@gmail.com>
Date:   Fri, 13 Jan 2023 09:15:14 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH] wifi: mac80211: fix memory leak in ieee80211_if_add()
To:     Zhengchao Shao <shaozhengchao@huawei.com>, netdev@vger.kernel.org,
        linux-wireless@vger.kernel.org, johannes@sipsolutions.net,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com
Cc:     weiyongjun1@huawei.com, yuehaibing@huawei.com
References: <20221117064500.319983-1-shaozhengchao@huawei.com>
Content-Language: en-US
From:   Eric Dumazet <eric.dumazet@gmail.com>
In-Reply-To: <20221117064500.319983-1-shaozhengchao@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/17/22 07:45, Zhengchao Shao wrote:
> When register_netdevice() failed in ieee80211_if_add(), ndev->tstats
> isn't released. Fix it.
>
> Fixes: 5a490510ba5f ("mac80211: use per-CPU TX/RX statistics")
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
>   net/mac80211/iface.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
> index dd9ac1f7d2ea..46f08ec5ed76 100644
> --- a/net/mac80211/iface.c
> +++ b/net/mac80211/iface.c
> @@ -2258,6 +2258,7 @@ int ieee80211_if_add(struct ieee80211_local *local, const char *name,
>   
>   		ret = cfg80211_register_netdevice(ndev);
>   		if (ret) {
> +			ieee80211_if_free(ndev);
>   			free_netdev(ndev);
>   			return ret;
>   		}


Note: I will send a revert of this buggy patch, this was adding a double 
free.