Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     Arend van Spriel <arend.vanspriel@broadcom.com>,
        Stefan Wahren <stefan.wahren@i2se.com>,
        Arend van Spriel <aspriel@gmail.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        SHA-cyfmac-dev-list@infineon.com
Subject: Re: brcmfmac: Unexpected cfg80211_set_channel: set chanspec ... fail, reason -52
References: <2635fd4f-dfa0-1d87-058b-e455cee96750@i2se.com>
        <1f428e2b-f73f-64ff-02d3-eefbcd11db89@broadcom.com>
        <ee24c4eda8d389ac7197b6296944e168ccc6b602.camel@sipsolutions.net>
Date:   Fri, 13 Jan 2023 15:35:51 +0200
In-Reply-To: <ee24c4eda8d389ac7197b6296944e168ccc6b602.camel@sipsolutions.net>
        (Johannes Berg's message of "Tue, 03 Jan 2023 08:07:41 +0100")
Message-ID: <878ri6d0aw.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Johannes Berg <johannes@sipsolutions.net> writes:

>> > [=C2=A0 104.897615] brcmfmac: cfg80211_set_channel: set chanspec 0x100=
e fail,=20
>> > reason -52
>
> [...]
>
>>=20
>> > All of these 10 errors are repeated every 60 sec.
>>=20
>> Catching up after the holidays ;-) Above chanspec values are invalid.=20
>> 0x100e =3D channel 14/bw 20MHz. The 'iw list' output shows all these=20
>> channels are disabled. So who/what is trying to set these channels.=20
>> Scanning sets the channel in firmware. Is this initiated from hostapd?=20
>
> Yeah, what userspace is running here? Looks like cfg80211_set_channel()
> is only used for survey?
>
> Couple of observations on the side:
>  * might be nice to have some "brcm" indication in that name :P

Indeed, having a function cfg80211_set_channel() in brcmfmac/cfg80211.c
is VERY misleading. I first though that is a cfg80211 function and
didn't understand Johannes' comment until I started grepping :) Can
someone fix that, please?

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes