Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 15 Jan 2023 14:13:44 +0200
From:   Leon Romanovsky <leon@kernel.org>
To:     Lizhe <sensor1010@163.com>
Cc:     kvalo@kernel.org, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, johannes.berg@intel.com,
        alexander@wetzel-home.de, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] wireless/at76c50x-usb.c : Use devm_kmalloc replaces
 kmalloc
Message-ID: <Y8Pt+IdfWBVy8nIA@unreal>
References: <20230113141231.71892-1-sensor1010@163.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230113141231.71892-1-sensor1010@163.com>
Precedence: bulk

On Fri, Jan 13, 2023 at 06:12:31AM -0800, Lizhe wrote:
> use devm_kmalloc replaces kmalloc

No, it is not.

> 
> Signed-off-by: Lizhe <sensor1010@163.com>
> ---
>  drivers/net/wireless/atmel/at76c50x-usb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/atmel/at76c50x-usb.c b/drivers/net/wireless/atmel/at76c50x-usb.c
> index 009bca34ece3..f486ddb83d46 100644
> --- a/drivers/net/wireless/atmel/at76c50x-usb.c
> +++ b/drivers/net/wireless/atmel/at76c50x-usb.c
> @@ -2444,7 +2444,7 @@ static int at76_probe(struct usb_interface *interface,
>  
>  	udev = usb_get_dev(interface_to_usbdev(interface));
>  
> -	fwv = kmalloc(sizeof(*fwv), GFP_KERNEL);
> +	fwv = devm_kmalloc(sizeof(*fwv), GFP_KERNEL);
>  	if (!fwv) {
>  		ret = -ENOMEM;
>  		goto exit;
> @@ -2535,7 +2535,6 @@ static int at76_probe(struct usb_interface *interface,
>  		at76_delete_device(priv);
>  
>  exit:
> -	kfree(fwv);
>  	if (ret < 0)
>  		usb_put_dev(udev);
>  	return ret;
> -- 
> 2.17.1
>