Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Eric Dumazet <edumazet@google.com>
Cc:     Lizhe <sensor1010@163.com>, davem@davemloft.net, kuba@kernel.org,
        pabeni@redhat.com, johannes.berg@intel.com,
        alexander@wetzel-home.de, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] wireless/at76c50x-usb.c : Use devm_kzalloc replaces kmalloc
References: <20230113133503.58336-1-sensor1010@163.com>
        <CANn89iKDXQ_nvnXBp5Q99P67AW-jFTNkpEmYdESDWitf0Nt4vw@mail.gmail.com>
Date:   Mon, 16 Jan 2023 08:32:37 +0200
In-Reply-To: <CANn89iKDXQ_nvnXBp5Q99P67AW-jFTNkpEmYdESDWitf0Nt4vw@mail.gmail.com>
        (Eric Dumazet's message of "Fri, 13 Jan 2023 14:44:58 +0100")
Message-ID: <87358bat16.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Eric Dumazet <edumazet@google.com> writes:

> On Fri, Jan 13, 2023 at 2:35 PM Lizhe <sensor1010@163.com> wrote:
>>
>> use devm_kzalloc replaces kamlloc
>>
>> Signed-off-by: Lizhe <sensor1010@163.com>
>> ---
>>  drivers/net/wireless/atmel/at76c50x-usb.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/atmel/at76c50x-usb.c b/drivers/net/wireless/atmel/at76c50x-usb.c
>> index 009bca34ece3..ebd8ef525557 100644
>> --- a/drivers/net/wireless/atmel/at76c50x-usb.c
>> +++ b/drivers/net/wireless/atmel/at76c50x-usb.c
>> @@ -2444,7 +2444,7 @@ static int at76_probe(struct usb_interface *interface,
>>
>>         udev = usb_get_dev(interface_to_usbdev(interface));
>>
>> -       fwv = kmalloc(sizeof(*fwv), GFP_KERNEL);
>> +       fwv = devm_kzalloc(sizeof(*fwv), GFP_KERNEL);
>
> Have you compiled this patch ?

Clearly not:

https://lore.kernel.org/linux-wireless/202301140533.jMlST9Ur-lkp@intel.com/

Lizhe, do not EVER submit untested patches. In some simple patches doing
just a compilation test might suffice, but please mention the patch is
only compile tested clearly in the commit log. But not even doing a
compilation test is a big no.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches