Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 16 Jan 2023 13:16:56 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Lorenzo Bianconi <lorenzo@kernel.org>
Cc:     nbd@nbd.name, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: mt76: mt7915: fix memory leak in
 mt7915_rate_txpower_get
Message-ID: <Y8VAOJmo89bn0qo1@lore-desk>
References: <2ea534ec17856f65237939f3d437aad37ddc7753.1672740921.git.lorenzo@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="iu/RfxLzqMCsTZCq"
Content-Disposition: inline
In-Reply-To: <2ea534ec17856f65237939f3d437aad37ddc7753.1672740921.git.lorenzo@kernel.org>
Precedence: bulk


--iu/RfxLzqMCsTZCq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Fix possible memory leak in mt7915_rate_txpower_get routine if
> mt7915_mcu_get_txpower_sku() fails.
>=20
> Fixes: e3296759f347 ("wifi: mt76: mt7915: enable per bandwidth power limi=
t support")
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
>  drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c b/driver=
s/net/wireless/mediatek/mt76/mt7915/debugfs.c
> index fb46c2c1784f..4730508652af 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
> @@ -990,14 +990,14 @@ mt7915_rate_txpower_get(struct file *file, char __u=
ser *user_buf,
>  	char *buf;
>  	u32 reg;
> =20
> -	buf =3D kzalloc(sz, GFP_KERNEL);
> -	if (!buf)
> -		return -ENOMEM;
> -
>  	ret =3D mt7915_mcu_get_txpower_sku(phy, txpwr, sizeof(txpwr));
>  	if (ret)
>  		return ret;
> =20
> +	buf =3D kzalloc(sz, GFP_KERNEL);
> +	if (!buf)
> +		return -ENOMEM;
> +
>  	/* Txpower propagation path: TMAC -> TXV -> BBP */
>  	len +=3D scnprintf(buf + len, sz - len,
>  			 "\nPhy%d Tx power table (channel %d)\n",
> --=20
> 2.39.0
>=20

Felix,

It seems there is already a fix for it in your tree so we can drop this pat=
ch.

Regards,
Lorenzo

--iu/RfxLzqMCsTZCq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCY8VAOAAKCRA6cBh0uS2t
rPk8AQCQcy3D9UTxz0yeYhKKhiVhljo1UMD5O2aknQuTLmPSqwEAvyrhZFY5/ej9
+agou0uuz7ZPTSYHIq9Lsx0XCIn0+QY=
=M+hI
-----END PGP SIGNATURE-----

--iu/RfxLzqMCsTZCq--