Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp3234334rwb; Mon, 16 Jan 2023 05:36:54 -0800 (PST) X-Google-Smtp-Source: AMrXdXu2bL/o7VOVNwbufb6q8Ez5LfobcSjVcseY8Ng0VBxeyR7gdmdpgtg2GuoeKa6SdrZeUTir X-Received: by 2002:a17:90a:5312:b0:226:f35f:923b with SMTP id x18-20020a17090a531200b00226f35f923bmr32180094pjh.2.1673876214381; Mon, 16 Jan 2023 05:36:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673876214; cv=none; d=google.com; s=arc-20160816; b=zjYSLgNnfSuLgkC8iPdp8Tx4tISA7Va11rTe8Awy35fDniE2JfT/aJd+h9+i8bol43 Jo2AKEbvuC2ndRdpbR9sQCZ+JqKT/QFDtxc/iJ8xPLN8lKHsIYsiGqrEql9KYId4GYDJ S7jMOrfspJ7wTrwAnPcfrhS+1YQeIyMgrOP7znBrZRMoR0BClDKEzbpMB6I0txUrU19j gvbSKdNHLMtu3LeRt8IMZq6OzG3QUAVfJqNS2r50XXY1+DJST+VL/9z+g3CUMBLq6Giu bZC692TwrrNzP4bsMK9GUBwbcwE4w3Kfw0Ov45wPjVV1qaUcnfXeFeWsIaM8e+Jy2XHO AEeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=V/VFIEO9Qs+TJapKggwW92IonpPoTO0K87CQfehq3Ks=; b=SBDXwx9Clox1KLqxurLVN4Y8f6pAVc+vaubvveuaY6ef2zZkd9GX7Csjjp6ASIeqcz 2ZYZtaj6Y/S+v21j2Qc2590u4F3axcuaG1TfzgEEYYMDFZOqR9yoTrisdrPPMF/CYSMm /wDWQ9RRN8lIPJESCQI6bCr8o7/1OGLjLQHUjQ26us83Zvrdzz10QM2biUEjzwZxInTT Gsx03AxREOl/kDBxxXr+bYj3mBe7fMK0TVoZQT2IWXC5xEzL/ajuC6xUKuw/HHUCoBUQ lUxReyz8LVTW2/vCnTR2cda4ExTNbPR23QMUIOaAU2y9lf9urPGk/DZrrjtSsAIeU9t4 rkEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=amx9IsfX; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b10-20020a17090ae38a00b00219c6a4b550si30933413pjz.103.2023.01.16.05.36.44; Mon, 16 Jan 2023 05:36:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=amx9IsfX; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230014AbjAPNb3 (ORCPT + 63 others); Mon, 16 Jan 2023 08:31:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230013AbjAPNb1 (ORCPT ); Mon, 16 Jan 2023 08:31:27 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41056B77F; Mon, 16 Jan 2023 05:31:26 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 039F7B80E90; Mon, 16 Jan 2023 13:31:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 008D5C433D2; Mon, 16 Jan 2023 13:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673875883; bh=qPUBxUXK2GS1PEFHaWB30Wa1xJGfN6u8M0tQhMj7ZJM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=amx9IsfXvgQ1Jy104SsPx7bm8BWVKd0z/6jVPkJmWfJ4ImJ7KVUccPsv2d99NJeBh Jy0N2p6r0ZgIKMMI3rquHvmMJ6YTA13rAlil3ol4+OZ6KzgcXxwKtYbeJzmETTTsM+ jreHbQaEZ5cdSQnM07XOMbtCI2AExtcU+yoEP+oFnDIM15Y4tFdKpgme3CLDKObIkk pdyWW+Gj3kpfOODcCn9edLAg12e33iI6E9FEH9n3WmMy17DZGfUggJZ1GWMKRXJeeX lRxFgIe76nciW3DLSbV95tKhgZ77sDbyFea2rLiokJzDqQL4ed7jxpP6OxA34/P87u htnlO+1HdCCyA== Date: Mon, 16 Jan 2023 15:31:19 +0200 From: Leon Romanovsky To: Kalle Valo Cc: yang.yang29@zte.com.cn, aspriel@gmail.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, sha-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xu.panda@zte.com.cn Subject: Re: [PATCH net-next] brcm80211: use strscpy() to instead of strncpy() Message-ID: References: <202212231037210142246@zte.com.cn> <167387451256.32134.6493247488948126794.kvalo@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <167387451256.32134.6493247488948126794.kvalo@kernel.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, Jan 16, 2023 at 01:08:36PM +0000, Kalle Valo wrote: > wrote: > > > From: Xu Panda > > > > The implementation of strscpy() is more robust and safer. > > That's now the recommended way to copy NUL-terminated strings. > > > > Signed-off-by: Xu Panda > > Signed-off-by: Yang Yang > > Mismatch email in From and Signed-off-by lines: > > From: > Signed-off-by: Yang Yang > > Patch set to Changes Requested. Kalle, please be aware of this response https://lore.kernel.org/netdev/20230113112817.623f58fa@kernel.org/ "I don't trust that you know what you're doing. So please don't send any more strncpy() -> strscpy() conversions for networking." Thanks > > -- > https://patchwork.kernel.org/project/linux-wireless/patch/202212231037210142246@zte.com.cn/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches >