Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp3237998rwb; Mon, 16 Jan 2023 05:39:53 -0800 (PST) X-Google-Smtp-Source: AMrXdXuYvVtmvQitX2bCiamoeFKwIYe3hb3NJUCL6ejuY7GJXA6+SPCR4IFiatX1JYkCzVtzsW2Z X-Received: by 2002:a05:6a20:a012:b0:b8:9c21:f53f with SMTP id p18-20020a056a20a01200b000b89c21f53fmr2499880pzj.46.1673876393229; Mon, 16 Jan 2023 05:39:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673876393; cv=none; d=google.com; s=arc-20160816; b=oa106qSYcBDEMtya4ms3tXKI9uTJL50un2KEU6PARTJRmErD85SKj6zN3QQIgQutEy AxM0XYYLrjwqwBPTA0haRUsxQ/CfVxwplC7vlwKP72ms2SJ/+kXFb8YJevo3BOJNuVUu 59b1zo8cBAu+f50zJn6Pa5mkXJc/tsj2Y5nVKZg7SICnr9Ka72UJ8bFshng2kRoBu/Xw 01eRsQ2y4aO6FqQQ+fMsVU7eaxSJtW98iCJu7XM8MqMiJwBHLeVbeyMPOV1I0+81Sx2t CP5mno7R2owyPdII0WHjEbbvf1P7nTFQLAkJeZs2wlKqvIi1yYTDaXLDvgSj/J9sl9oz usPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=qDGvg7K34itogh3NDYN/nkeifxFgly/bt3IBW0uBlIg=; b=JF3qWoMG540TfK4qARYvFp3A5USXhh3R7g958uFXGMvvvfl0UiUnc3luCIMK/L4WfA yqBYZAMGbxudZjJ+RsLuo7/Nt2Prxvml1oYh2zMExw7rRhkt/yObkLyEMf9J6SIM+9h8 Q7XgQXYvwTUStkezDAhQlmodOKJb7otguXJnV/1H7NpoDl0IqmjuQoNPYp7Bq0fzF9GS 5M8dcVrBd083r+OcglRbKMNdJK/PV7wnss/YHjzuvYtXbmc19Tq7cyW2LTgLbrdXIvm2 KUcfivzM938nIv/GZcUDzll+D+TTeDw28OS71bo4KVWSTp2raejAsYaOJZe5bKk7k7nR wJyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L4mWU62i; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a6-20020a656046000000b004794d65bc1esi26207129pgp.399.2023.01.16.05.39.45; Mon, 16 Jan 2023 05:39:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L4mWU62i; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231165AbjAPNgO (ORCPT + 63 others); Mon, 16 Jan 2023 08:36:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230484AbjAPNgC (ORCPT ); Mon, 16 Jan 2023 08:36:02 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1953914E82 for ; Mon, 16 Jan 2023 05:36:02 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C8D78B80EAF for ; Mon, 16 Jan 2023 13:36:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4D37C433F2; Mon, 16 Jan 2023 13:35:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673876159; bh=iZ/wCf2sZxY0iT03UGsul0Yx02aVmA3WRKTpV+V9Ya0=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=L4mWU62iVdE3cQZbVXOeL27eQM1+sVjFX1fzUZjw8K0okq/aiTK9FO7wteFD4J1ZB s8BbrZIHb04QN0hUq2dptag//S2hyHCxRR5rdVchWZ8BBMW4XhTB4kkBm/tRChPM6q n4fAurBCQ1K7cZTs2FKmEm456lLGb5vB3zsu/sBvk5Yvc1Ti/Q8NbJBXk7nQX6dH1f NnAPbGmtFipahaaoOZdakzKDiV9YTXyRxFFlPV6hqpHOKy+p28RjFWQlZ1xSI9b4qu znsCLRQBcn95pCl1t5gnJQK+zkIfBoUlQ40LLhtJbYZllGu9Yks1ldRsKNqwM97xyL BE4JoqEsYnFjg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtw89: fix potential leak in rtw89_append_probe_req_ie() From: Kalle Valo In-Reply-To: <20230103141054.17372-1-pkshih@realtek.com> References: <20230103141054.17372-1-pkshih@realtek.com> To: Ping-Ke Shih Cc: , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <167387615699.32134.3213630123996203413.kvalo@kernel.org> Date: Mon, 16 Jan 2023 13:35:58 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Ping-Ke Shih wrote: > From: Zong-Zhe Yang > > Do `kfree_skb(new)` before `goto out` to prevent potential leak. > > Fixes: 895907779752 ("rtw89: 8852a: add ieee80211_ops::hw_scan") > Signed-off-by: Zong-Zhe Yang > Signed-off-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 4a0e218cc9c4 wifi: rtw89: fix potential leak in rtw89_append_probe_req_ie() -- https://patchwork.kernel.org/project/linux-wireless/patch/20230103141054.17372-1-pkshih@realtek.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches