Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp3241414rwb; Mon, 16 Jan 2023 05:42:43 -0800 (PST) X-Google-Smtp-Source: AMrXdXu5mQp989ADZT21Y9azQss/yJxx3UPVqWc70J+F0Chau9rNnpCuw9q1vMn2+U+mXKxHaM2M X-Received: by 2002:a05:6a20:9d8e:b0:b8:a247:f39f with SMTP id mu14-20020a056a209d8e00b000b8a247f39fmr1387637pzb.7.1673876562763; Mon, 16 Jan 2023 05:42:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673876562; cv=none; d=google.com; s=arc-20160816; b=KciO8+5xg+AzhamLr9q+lFKpLiSKc2qqFsdzul806BuhGSWZanoGjX4e9u9zeVqxh4 iQM1FAushVPt/47w7ljSYIy5r0ODlj+WfildonOaLrJRbuYW1nHB4/KnKMMcREYpY7cE z4otuS7FCzPb9LH0Nk7yU/qyf86A9bI2nhNlFwulbgvu7xjABuQOom8QbIKzYrQJIWFa XXmrm9HHkt6YEWPVcBYUS/zgceSliW9XOIB+RoNg2QPyS4scVQN4l7tAu6IiiZ0WW3AE j88cOgVWSCcXqGe8wMWNO2upT5QmV54EA6Uj80ACPVDDL2FxCpm+aR6NW/tqfmWvyCFN MJVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=olYhnULxheyFAmpCiKEbqNDFlNHhsXm0okV0GyDiURs=; b=zMKJVc45ej6xB+4AcmBBkLYNR76/nvui+kgJ/ca+26vdatIbOWkjGFqV/gsbQQQsix u2+90WXsI3fbzKLP8ZZA6/ZwTXvtNa2c/ItLBMAVbFXMGrcWZlauuqMgW680kfWBgEPf kswEaGO6XKcN05hNgZ9cBVV4A419976Iv9xU0BiB29+fSA4ed9b9bScviNV9Y0Goraqs VLv1v1sRKR1lVnAjVF+B2eAC1zRsAq+3Nuuq54O7dq7+lsTwzYoiJdoU9baN4OON37Or rx6qgQePLj3SXPAorqWz55UAZr3MYTgjRA8jPm9AoD/oXvUHkkTMiIjbTR3rx2rPyZTs sY0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Bm5O53gF; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n1-20020a63e041000000b00477cd382329si30370293pgj.56.2023.01.16.05.42.35; Mon, 16 Jan 2023 05:42:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Bm5O53gF; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231173AbjAPNgf (ORCPT + 63 others); Mon, 16 Jan 2023 08:36:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231135AbjAPNgb (ORCPT ); Mon, 16 Jan 2023 08:36:31 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B70621E1C3; Mon, 16 Jan 2023 05:36:30 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7BFEBB80E96; Mon, 16 Jan 2023 13:36:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1CEFC433EF; Mon, 16 Jan 2023 13:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673876188; bh=eyYIBkTc+aU5rlU29lHgxKy0T+h5OUzw65jzZNbXujU=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Bm5O53gFx9vK77BY7dGcTm1p1nvPvVgjuWT4h3LdiJmqXPT9r5FUBTBWJSAAzr3lt bwTtIQqPnlPOw7qTszmAKbXG8W1YgTnawhilcjbsjrshDf99JmJeDp2r/MaRfcekc+ wMLfX4rr72LPcZik9OZgn/IE7Jwz84LM1XJZqjTZ1VPZ+z0m/rIfC9mKlmU3rZnpDM 8+IOoCZ0KvNEESQzaRd4J89u6E6KDzf1+tN8JPZ9sgOTDnkLEoRlnt/IzNmPT1HF+U UfN45rcf418e7Zn4E328UTljRqZQm7N2FkSoXpg8bg/JtbDEaOAP1rG+mfLQXALQ9t sMsFOdZZN1ewA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] wifi: rtw89: Add missing check for alloc_workqueue From: Kalle Valo In-Reply-To: <20230104142901.1611-1-jiasheng@iscas.ac.cn> References: <20230104142901.1611-1-jiasheng@iscas.ac.cn> To: Jiasheng Jiang Cc: leon@kernel.org, pkshih@realtek.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiasheng Jiang User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <167387618418.32134.12212618077257685528.kvalo@kernel.org> Date: Mon, 16 Jan 2023 13:36:25 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Jiasheng Jiang wrote: > Add check for the return value of alloc_workqueue since it may return > NULL pointer. > Moreover, add destroy_workqueue when rtw89_load_firmware fails. > > Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver") > Signed-off-by: Jiasheng Jiang > Acked-by: Ping-Ke Shih > Reviewed-by: Leon Romanovsky Patch applied to wireless-next.git, thanks. ed9e6166eb09 wifi: rtw89: Add missing check for alloc_workqueue -- https://patchwork.kernel.org/project/linux-wireless/patch/20230104142901.1611-1-jiasheng@iscas.ac.cn/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches