Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Leon Romanovsky <leon@kernel.org>
Cc:     yang.yang29@zte.com.cn, aspriel@gmail.com, franky.lin@broadcom.com,
        hante.meuleman@broadcom.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        sha-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, xu.panda@zte.com.cn
Subject: Re: [PATCH net-next] brcm80211: use strscpy() to instead of strncpy()
References: <202212231037210142246@zte.com.cn>
        <167387451256.32134.6493247488948126794.kvalo@kernel.org>
        <Y8VRpzodki/YAcvC@unreal>
Date:   Mon, 16 Jan 2023 17:18:32 +0200
In-Reply-To: <Y8VRpzodki/YAcvC@unreal> (Leon Romanovsky's message of "Mon, 16
        Jan 2023 15:31:19 +0200")
Message-ID: <87y1q2y0c7.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Leon Romanovsky <leon@kernel.org> writes:

> On Mon, Jan 16, 2023 at 01:08:36PM +0000, Kalle Valo wrote:
>> <yang.yang29@zte.com.cn> wrote:
>> 
>> > From: Xu Panda <xu.panda@zte.com.cn>
>> > 
>> > The implementation of strscpy() is more robust and safer.
>> > That's now the recommended way to copy NUL-terminated strings.
>> > 
>> > Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
>> > Signed-off-by: Yang Yang <yang.yang29@zte.com>
>> 
>> Mismatch email in From and Signed-off-by lines:
>> 
>> From: <yang.yang29@zte.com.cn>
>> Signed-off-by: Yang Yang <yang.yang29@zte.com>
>> 
>> Patch set to Changes Requested.
>
> Kalle, please be aware of this response
> https://lore.kernel.org/netdev/20230113112817.623f58fa@kernel.org/
>
> "I don't trust that you know what you're doing. So please don't send
> any more strncpy() -> strscpy() conversions for networking."

Good to know, thanks.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches