Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Aaron Ma <aaron.ma@canonical.com>
Cc:     nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com,
        shayne.chen@mediatek.com, sean.wang@mediatek.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, matthias.bgg@gmail.com,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: mt76: mt7921: fix error code of return in mt7921_acpi_read
References: <20230116152235.1433484-1-aaron.ma@canonical.com>
Date:   Mon, 16 Jan 2023 17:41:39 +0200
In-Reply-To: <20230116152235.1433484-1-aaron.ma@canonical.com> (Aaron Ma's
        message of "Mon, 16 Jan 2023 23:22:35 +0800")
Message-ID: <87tu0qxz9o.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Aaron Ma <aaron.ma@canonical.com> writes:

> Kernel NULL pointer dereference when ACPI SAR table isn't implemented well.
> Fix the error code of return to mark the ACPI SAR table as invalid.
>
> [    5.077128] mt7921e 0000:06:00.0: sar cnt = 0
> [    5.077381] BUG: kernel NULL pointer dereference, address:
> 0000000000000004
> [    5.077630] #PF: supervisor read access in kernel mode
> [    5.077883] #PF: error_code(0x0000) - not-present page
> [    5.078138] PGD 0 P4D 0
> [    5.078398] Oops: 0000 [#1] PREEMPT SMP NOPTI
> [    5.079202] RIP: 0010:mt7921_init_acpi_sar+0x106/0x220
> [mt7921_common]
> ...
> [    5.080786] Call Trace:
> [    5.080786]  <TASK>
> [    5.080786]  mt7921_register_device+0x37d/0x490 [mt7921_common]
> [    5.080786]  mt7921_pci_probe.part.0+0x2ee/0x310 [mt7921e]
> [    5.080786]  mt7921_pci_probe+0x52/0x70 [mt7921e]
> [    5.080786]  local_pci_probe+0x47/0x90
> [    5.080786]  pci_call_probe+0x55/0x190
> [    5.080786]  pci_device_probe+0x84/0x120
>
> Fixes: f965333e491e ("mt76: mt7921: introduce ACPI SAR support")
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>

Felix, if this is ok should this go to v6.2?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches