Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: wifi: orinoco: check return value of hermes_write_wordrec()
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20221227133306.201356-1-aleksei.kodanev@bell-sw.com>
References: <20221227133306.201356-1-aleksei.kodanev@bell-sw.com>
To:     Alexey Kodanev <aleksei.kodanev@bell-sw.com>
Cc:     linux-wireless@vger.kernel.org,
        Alexey Kodanev <aleksei.kodanev@bell-sw.com>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <167388616414.5321.302246308386486154.kvalo@kernel.org>
Date:   Mon, 16 Jan 2023 16:22:45 +0000 (UTC)
Precedence: bulk

Alexey Kodanev <aleksei.kodanev@bell-sw.com> wrote:

> There is currently no return check for writing an authentication
> type (HERMES_AUTH_SHARED_KEY or HERMES_AUTH_OPEN). It looks like
> it was accidentally skipped.
> 
> This patch adds a return check similar to the other checks in
> __orinoco_hw_setup_enc() for hermes_write_wordrec().
> 
> Detected using the static analysis tool - Svace.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>

Patch applied to wireless-next.git, thanks.

1e346cbb096a wifi: orinoco: check return value of hermes_write_wordrec()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20221227133306.201356-1-aleksei.kodanev@bell-sw.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches