Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp3485977rwb; Mon, 16 Jan 2023 08:36:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXtzSTS6DQhhk5nNEvgUbRiADKC9pKGEgjWUGWZlAYxOxDLq6M/gIUBoXVEcMVtnAJj1Vr5N X-Received: by 2002:a17:90b:48c9:b0:229:6bff:d336 with SMTP id li9-20020a17090b48c900b002296bffd336mr5388522pjb.10.1673886990672; Mon, 16 Jan 2023 08:36:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673886990; cv=none; d=google.com; s=arc-20160816; b=mR685rmsf0Nas1JQMko6rzsYB8bG80C00puh0DUChQipVJUrafXCk+30EjeCjf764s 9fjHJARwAakcWLO+MtsRzpXcT+n22uUmg7yDZCqppoNNMLtwVf326pkv7wzgb15uM0Sg qUw3unEjBmS+Ug0YjiTcl+oxBr9lkbPJVq8Ehs+QIPEPN3akCXFqyIA2lb3h7zeQ/PY8 weLDbkkyw8aGD3dTtaGA/KhsTPJG0c47GVBoR9J8Fcc7AL5Qm3wOH9DBHqRhToJGchui Gny3yoKZto6uznD3Ixs/iML9rA36LE9eKtVSlF//bx+1GSuGan9xj3Sh6X4I/HswNs/I n+dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=/Oa0d45nrWXYugXKKGj3tjVhXQIfnr5RFDZ+D+AYnIQ=; b=e5GythPCjXyaIXxjOFjLPIIWu/DQMLDP06a04ppcZ5F93A5d5YHOic30F4FNrSue1N 54Zq55gASQDs8uW9VmpRDXyQNyRnMpJYw8/TpJWZk33Jpud6eyXoFUcH2qdoiCyVQiLf bcZ+hY6LWt1vkbxNG1mbqUJ69RbaRUaN+gqlGr+ZWDj9dN02X5jeAnSbMoNqjHiM6wQB ruf5NBv/rXuGDr6paBy2QTt72PEA1Nkhz+3s1FJxvzkIC3buD9VS5oGux7xjidCx3exU Tw75EPBNqPyj3IUaUilBoq4ZYkHcxK8PKMSr/7ZQOHgF8TmYwH95dMCNViusqAMD932c Z8Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WXwjYVnb; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mw12-20020a17090b4d0c00b002270c47059asi25696473pjb.114.2023.01.16.08.36.23; Mon, 16 Jan 2023 08:36:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WXwjYVnb; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233523AbjAPQgJ (ORCPT + 63 others); Mon, 16 Jan 2023 11:36:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233038AbjAPQfx (ORCPT ); Mon, 16 Jan 2023 11:35:53 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9590F30EA7; Mon, 16 Jan 2023 08:24:06 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4902FB81065; Mon, 16 Jan 2023 16:24:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 705F2C433F1; Mon, 16 Jan 2023 16:24:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673886244; bh=Xa4zXDzPxuSD1mCwh5IIhSowSMlMbPBGb/rtmYiebas=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=WXwjYVnbosQ1VJJhJrleDAHRCqHh1veZTk6xuE7/uy6CythCGIrKTsIVdVasrrgvu niilM4/tp7llmASXnxH+EV5eeIK/1r+V995ZVTtD8s2MBPAdsKjxN0m3VQxirM61zU 6ekDcfUu2yivuQWacrymNjyounhrLfBpvgs/UyFomcB2OwwHa2OTrZ80LBTK7SNhBe xTbXnddsHb9+OAHRpkrS0vu2L+NoLeeIdLMHfJKqFIXD7pTxkX0rzY7LcM/kjKyMT5 4LQGhBxOWoJWg9EJWmKqBBc0fifM9fs55aBIRnUKdQb+uFoIlpc0ek0VwFz8h3pAND wSuqDeKesS5hg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] wifi: rt2x00: Remove useless else if From: Kalle Valo In-Reply-To: <20230106022731.111243-1-jiapeng.chong@linux.alibaba.com> References: <20230106022731.111243-1-jiapeng.chong@linux.alibaba.com> To: Jiapeng Chong Cc: stf_xl@wp.pl, helmut.schaa@googlemail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <167388623942.5321.8431065442138350705.kvalo@kernel.org> Date: Mon, 16 Jan 2023 16:24:01 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Jiapeng Chong wrote: > The assignment of the else and else if branches is the same, so the else > if here is redundant, so we remove it. > > ./drivers/net/wireless/ralink/rt2x00/rt2800lib.c:8927:9-11: WARNING: > possible condition with no effect (if == else). > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3631 > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > Acked-by: Stanislaw Gruszka Patch applied to wireless-next.git, thanks. ebe8dee7aea6 wifi: rt2x00: Remove useless else if -- https://patchwork.kernel.org/project/linux-wireless/patch/20230106022731.111243-1-jiapeng.chong@linux.alibaba.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches