Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp4457850rwb; Tue, 17 Jan 2023 00:45:59 -0800 (PST) X-Google-Smtp-Source: AMrXdXvr6cDPP2olzG2r86s9NrRZLYbXh1rNZWG2pK3Dcp26iI8CA7guoOkLs9Kx7LoGD1sIBYtq X-Received: by 2002:a05:6a20:b282:b0:a3:a90f:5326 with SMTP id ei2-20020a056a20b28200b000a3a90f5326mr1660695pzb.61.1673945158829; Tue, 17 Jan 2023 00:45:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673945158; cv=none; d=google.com; s=arc-20160816; b=jWKaTj+qleDkr2hAJ+TGmVad0h1Nl7miXrtlG9w47a0wyHivTjtm64F8wldgrs2Xg3 kZmsHwpufbwB+5qmTXVahjJ0YaVV/DGOYWYtWoWKIOVrBXJrzruiZvTHpQLqo1X/O3ja n8eBmU2ziZtfSqeiCb1X6DpM3nTpKghnnYSVGzNRBwbcrijjNtW7MOn4kaBrPiRFNXLj XOGeR1WTRAk/C2e2XZFcq+8+TFORMpTbuvYV/K/Kmn4XomFhI4lpPJg1pvneoKTxtXy4 OI14vyLONP1/dCVf5Y8ZEFP7cVYpK5MazhUhSiGuWXrFoaI3Bw9XP0/NxCXR2ZbEFvK+ qynA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:cc:user-agent:mime-version :date:message-id:dkim-signature; bh=4qWtUJJQh4AJ77vzNG8TOT9dacrDX5G5ALwjggIKjcQ=; b=tlRg1hQwiFL6TtwAtjpd6PzLDyrHFirr3xZeUjqfGt5JoCmbdOnf139wdkkOF4wI5w mI+DaJz6pMS4LRO9urWU1M7hdWRbnQ8idJdHEZ1wBG6xbF5+Yw9x2icgIr5TjP6AZdqB xVhxbXBWEBZH+BSmANce6V/fls6LLt4UJQ0/nUAAFmOpydf7wLwGRKfw54780INqWWiC k/Bw+up/jwXo1G61TsnjdE3seCZFY73ts0taNhFXbNZ3kWH5kdKXBswuaQrfv5rABe2O 2UMYABAreQT+Yto2As2ZxPPjkkuS+L4W1tXWjlw14IKf7/z+K2Y1xz90YXSJnWmGIWTe 1y8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kC944rst; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b24-20020a63d318000000b00478ba6bfcf0si31111255pgg.703.2023.01.17.00.45.48; Tue, 17 Jan 2023 00:45:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kC944rst; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236264AbjAQIhJ (ORCPT + 63 others); Tue, 17 Jan 2023 03:37:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236220AbjAQIgO (ORCPT ); Tue, 17 Jan 2023 03:36:14 -0500 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C13C27488; Tue, 17 Jan 2023 00:36:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673944567; x=1705480567; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=+/sep6cg202vL4sr/HrqlldWJYwNCPz0Civ/zJRrPiM=; b=kC944rsttNMM+kTKzgf2E/C+rzjwxmZRrkJVXgzZ3EiDmtz6Rw40MWbC 5UEHD4aWdxRx1XjE2T0TxTgPNmZW4mgstfaKJ1TiE2tqdQoXQV/I1Vruw OmJougsFpSQY1CGfNOek7e8WxJ/dko6ceEu1BDK7Sr1lJ94Ero8exXZ4i N1kZQ9oiW6Svwt2hLBk7ruV4FdOWgbeMKQLoEKaP0XZbWofYBFkIQhD6i ls74gTBUo3uw+C9XyVghHutEPDYX2MkNJnMtn5xg2bq+lUwBJruN2OwX7 FmOWdhSb7y5Mt/72NB/NfMjejUuvzSKs3mZKm7E6h1hTW2HRqvRsygxyo w==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="324696291" X-IronPort-AV: E=Sophos;i="5.97,222,1669104000"; d="scan'208";a="324696291" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 00:36:06 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="783168240" X-IronPort-AV: E=Sophos;i="5.97,222,1669104000"; d="scan'208";a="783168240" Received: from blu2-mobl.ccr.corp.intel.com (HELO [10.252.187.178]) ([10.252.187.178]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 00:35:59 -0800 Message-ID: Date: Tue, 17 Jan 2023 16:35:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Cc: baolu.lu@linux.intel.com, Alex Williamson , "ath10k@lists.infradead.org" , "ath11k@lists.infradead.org" , Christian Borntraeger , "dri-devel@lists.freedesktop.org" , "iommu@lists.linux.dev" , "kvm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" , "linux-media@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-tegra@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "nouveau@lists.freedesktop.org" , Niklas Schnelle , "virtualization@lists.linux-foundation.org" Subject: Re: [PATCH 7/8] iommu/intel: Support the gfp argument to the map_pages op Content-Language: en-US To: "Tian, Kevin" , Jason Gunthorpe , Joerg Roedel , Matthew Rosato , Robin Murphy References: <0-v1-6e8b3997c46d+89e-iommu_map_gfp_jgg@nvidia.com> <7-v1-6e8b3997c46d+89e-iommu_map_gfp_jgg@nvidia.com> From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2023/1/17 11:38, Tian, Kevin wrote: >> From: Jason Gunthorpe >> Sent: Saturday, January 7, 2023 12:43 AM >> >> @@ -2368,7 +2372,7 @@ static int iommu_domain_identity_map(struct >> dmar_domain *domain, >> >> return __domain_mapping(domain, first_vpfn, >> first_vpfn, last_vpfn - first_vpfn + 1, >> - DMA_PTE_READ|DMA_PTE_WRITE); >> + DMA_PTE_READ|DMA_PTE_WRITE, >> GFP_KERNEL); >> } > Baolu, can you help confirm whether switching from GFP_ATOMIC to > GFP_KERNEL is OK in this path? it looks fine to me in a quick glance > but want to be conservative here. This is also good for me. The memory notifier callback runs in a process context and allowed to block. Best regards, baolu