Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp4465114rwb; Tue, 17 Jan 2023 00:54:32 -0800 (PST) X-Google-Smtp-Source: AMrXdXvL2hYJrKnDoXG+3MVT70ctFEPOEzZGR9tiRCAyUx31um15g9QrMsZ9bUa0bjK1prD/BdZT X-Received: by 2002:aa7:9d92:0:b0:58a:aaa3:f72e with SMTP id f18-20020aa79d92000000b0058aaaa3f72emr24245537pfq.6.1673945672689; Tue, 17 Jan 2023 00:54:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673945672; cv=none; d=google.com; s=arc-20160816; b=MdCQzE/ekdqC4/G5/ihhVAZmudCSiH5+hSINs5XIdL9e28SbVWCfY5AHiQd7YLn7RQ kR+WcqKYF1ftbC12g4arbGMdckOKT64YYGC9SanEo9mVGwae1YS4pPYKV9Zw2eUUafY3 EVZBnhMNT6FjfEsNsBv9hRqK7Be+aJ+lPCSLDcctKxz0DQ/aLqzuhhRyy0ITbGpernAN cMsAxXFKKo8j4zcno1cFVOCDbera3JHTtBVAtT4qw8bChtBg/eh7BrVpFViHNGapDOys HiYfOzffdk9/8XP3T3A629K+AXlT30SKILXQyEiEiJSLvRyFzyFDeGCSBSWTfwIMHdZr nLaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=H906UnaT+mKc1vvKmTCCEcWqGmxotatY633LkzBqxYU=; b=ARMisrG1HQwNn0t9/ulUZYzyuBCI1bH2zOupu6vtZ9X0qrMt/nlxVSijWmsGmTc6yU hx8x+/R1P7Xt3yrFo/oU6XLOC0/uA31ssZwpP3HQG/WNuWMAnAJMkKu/WjA4DD64NO6S 2tXHmMr6iJgTrS2nwaCk1Ze6ftW+b1Fqy46rvlmzW1GGBof/4ME4uAUdE7g5k+ralfQz JIpDAPA0QjQAZ2RZYrmHtZ6VqG1TFw4jnjAK1+hKxjdkNzN4pXJeH0yF1iWOPXa3CBUR 19Di/GiiuBjRzg0T+RhXldAwqA36MXUCn5tT5uSRAhf98RB1AaL3PsSB1RbZrf6cvE5Q jJQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=A6BVq7HN; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j11-20020a056a00174b00b0058bcb6283edsi9750212pfc.288.2023.01.17.00.54.24; Tue, 17 Jan 2023 00:54:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=A6BVq7HN; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236224AbjAQIt6 (ORCPT + 63 others); Tue, 17 Jan 2023 03:49:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235898AbjAQItv (ORCPT ); Tue, 17 Jan 2023 03:49:51 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EA74EC47; Tue, 17 Jan 2023 00:49:51 -0800 (PST) Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30H7jBg2002153; Tue, 17 Jan 2023 08:49:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=H906UnaT+mKc1vvKmTCCEcWqGmxotatY633LkzBqxYU=; b=A6BVq7HNMg+oOk9phju+5wb8NvQ5nhXgUGV4aDzrytllvMMkF1QwAASO805mzs95eZ2n nFKcix/B9tP3yq5RutbLwr2yS0Abm57uKLmBtWu1LQCnzO68gBvKuRAubGf/f3lwbm/t d7yQv+5f0SONkcFHHSaAcX07ZpD4eOvZsvKy1FKh8tdh0yhzrWgHCxFAGAnbCx2hVThN Rond9aWSHw3YaiM/1OecQ05uP252qJXP3SYTDx0h1dBaObZJqgSUfIb/xpcCfRKWX9Px JCMj5JyJGhH44nebnIBpCrl3064gZ9Rc08Ewv1HQn0ismQJBIsB7Inz4PAelp10g6+mT Qw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3n5hky0gqv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Jan 2023 08:49:29 +0000 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 30H8ftP6001523; Tue, 17 Jan 2023 08:49:28 GMT Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3n5hky0gq2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Jan 2023 08:49:28 +0000 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 30GGKqhH025576; Tue, 17 Jan 2023 08:49:26 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma05fra.de.ibm.com (PPS) with ESMTPS id 3n3m16ajt5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Jan 2023 08:49:26 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 30H8nMXa14222046 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Jan 2023 08:49:22 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CAED920049; Tue, 17 Jan 2023 08:49:22 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 33E1620040; Tue, 17 Jan 2023 08:49:22 +0000 (GMT) Received: from [9.155.211.163] (unknown [9.155.211.163]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 17 Jan 2023 08:49:22 +0000 (GMT) Message-ID: <0bd438b3afa979b9f4d4d1e9c76451a93e7ef7eb.camel@linux.ibm.com> Subject: Re: [PATCH 8/8] iommu/s390: Push the gfp parameter to the kmem_cache_alloc()'s From: Niklas Schnelle To: Jason Gunthorpe , Lu Baolu , Joerg Roedel , Kevin Tian , Matthew Rosato , Robin Murphy Cc: Alex Williamson , ath10k@lists.infradead.org, ath11k@lists.infradead.org, Christian Borntraeger , dri-devel@lists.freedesktop.org, iommu@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, linux-rdma@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org Date: Tue, 17 Jan 2023 09:49:22 +0100 In-Reply-To: <8-v1-6e8b3997c46d+89e-iommu_map_gfp_jgg@nvidia.com> References: <8-v1-6e8b3997c46d+89e-iommu_map_gfp_jgg@nvidia.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: MKx4-ANHPJUrZonOgwaEaY-EVKsDWzHU X-Proofpoint-GUID: SbFxmq8QKSSdWBsgb5noBKiad8Yo5FPz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-17_04,2023-01-13_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=713 bulkscore=0 spamscore=0 impostorscore=0 clxscore=1011 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301170071 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2023-01-06 at 12:42 -0400, Jason Gunthorpe wrote: > dma_alloc_cpu_table() and dma_alloc_page_table() are eventually called by > iommufd through s390_iommu_map_pages() and it should not be forced to > atomic. Thread the gfp parameter through the call chain starting from > s390_iommu_map_pages(). >=20 > Signed-off-by: Jason Gunthorpe > --- > arch/s390/include/asm/pci_dma.h | 5 +++-- > arch/s390/pci/pci_dma.c | 31 +++++++++++++++++-------------- > drivers/iommu/s390-iommu.c | 15 +++++++++------ > 3 files changed, 29 insertions(+), 22 deletions(-) >=20 ---8<--- > =20 Looks good to me and I have no objections. Reviewed-by: Niklas Schnelle