Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp4699033rwb; Tue, 17 Jan 2023 04:30:23 -0800 (PST) X-Google-Smtp-Source: AMrXdXtm2B1Y7oeT1s8VbJA0fy3eL95ztW7aWU+LELB0k2OLGpMZuqJez2sF6//Vp7zcXu3+vZ66 X-Received: by 2002:a05:6402:174d:b0:494:eb9:54c4 with SMTP id v13-20020a056402174d00b004940eb954c4mr2689290edx.19.1673958623596; Tue, 17 Jan 2023 04:30:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673958623; cv=none; d=google.com; s=arc-20160816; b=cs+hiEDAaSA6TpB6HttVWr0CNVA0km9gX4C1/LiwWCmmdh4MBiFaAUnQDC029OpL1z mrs7STK1lxcitPi4cV6DfzlhsFEZMEr4eHLK3PCdEXX+SsSm3AJKI14p9uwW+U8iCc1t Prrizv5Q8eAMRGE6aTFydXQLpQTblqElvla9tgmCjDtctIq2/Vi1Ac65SkJyLGO1/Mp3 eF8Fa5Qi6SwI8HHLr2cfSD4YE4OH3pg6D2yJ3BovvmlSqVv6RRwHsxc+qOFYWwU5iPrJ jT/XXxiUqNT0P6wY2S2qcd0oPr/kMMiTkAw67EGFQU7R6Xz+jJtPMGk9k3h2je1Ty8LJ bHXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:reporting-meta:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dkim-signature; bh=rSfuiJxxoteBB8nWQz9EHh3tEZgaUdP09an5J6pNf38=; b=slpXNcVwm2Cj0MtpELCTl13zW/Sa5YoVOp/Gcb4JEZpYJ8x8DKx/NJv8BfOxw7pT5r 4nkqN+iy0IabBWljbA6HbM9GO3cEACBN6Uh8nLGbXnbELe+RiljZcbkacz5tLA4R9pcQ glkBVwE4jZlM6QwafwPMM5tTNNgGmFM6WeRISYmehv4gfdTQkPb6DYrnYiBTx0njeTFs KWAJ4Wh9iO52BBjl7IUB0ihOvKbi4GGRvpveQl23cxTQJMy9YB35h7OshAfqDB6Dxtgw DNi0s2eYT+KIaQlEVA2p17BOoY4xfXb2jXgrzGKo8p2loUFOQ2JeGKfAUYxFURn9tMZL Qg1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@n8pjl.ca header.s=oci-2023 header.b=Ca+6e6eX; dkim=pass header.i=@yyz1.rp.oracleemaildelivery.com header.s=prod-yyz-20200204 header.b=GZ7CnAVc; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=n8pjl.ca Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i18-20020aa7dd12000000b0049ba9628196si14296997edv.366.2023.01.17.04.30.03; Tue, 17 Jan 2023 04:30:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@n8pjl.ca header.s=oci-2023 header.b=Ca+6e6eX; dkim=pass header.i=@yyz1.rp.oracleemaildelivery.com header.s=prod-yyz-20200204 header.b=GZ7CnAVc; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=n8pjl.ca Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236336AbjAQM2z (ORCPT + 63 others); Tue, 17 Jan 2023 07:28:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236237AbjAQM2y (ORCPT ); Tue, 17 Jan 2023 07:28:54 -0500 Received: from aib29gb126.yyz1.oracleemaildelivery.com (aib29gb126.yyz1.oracleemaildelivery.com [192.29.72.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4C16367D1 for ; Tue, 17 Jan 2023 04:28:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=oci-2023; d=n8pjl.ca; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender; bh=rSfuiJxxoteBB8nWQz9EHh3tEZgaUdP09an5J6pNf38=; b=Ca+6e6eX/idiXFhgWkZ7D0GoBiwBySUcpRLuBgaSSf7WCNoIf93HVFyXs2rXrg79akmrx5hPgob8 J4uo/G9z70lIKk5w03AJgW07l33g8cWFegZV45zqKh8AJA6vLeehyyAH0Uub3H+mqGAchJfrFORj jvH6vwLB2iidIf4eX6Fm09DdmRio+ARWKJjgMLejuf64irGwF7DAK1FXf+VjRhBRtk04SRZMJFEV 3dj0hLWm5riaQfl1Uzor68T1zmDpeywDettrbkd4aoxw+b4zU3NkHmV2xgiBDIwYntL3urpFM8g3 qOxrqmdExFI7DxTLM7fgicBY0H24TUpXb2ZnvQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=prod-yyz-20200204; d=yyz1.rp.oracleemaildelivery.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender; bh=rSfuiJxxoteBB8nWQz9EHh3tEZgaUdP09an5J6pNf38=; b=GZ7CnAVcXO/xzZb3LyWQTCFbbkqTNrLrZDZ/I3fePfWqk9SmeL67E2Wft45I8EiwQKT6Lm1Ff/ya EEkL6sCWlADcqYXncfvwy+ZFFx4lGAt5Ev5JEek1D1HtwgIkLUD21Px2iE2YJpR/iZ5KhXEVdWnu sjKbSgLAKQLebjvwg1e0LK/1PqsUgcVqYgfx8bK/7DEJ/d4nt+yifZ1RwhBLZWTr6FmeFJGPLSfW KPiof34RG2EJDvf4LK8u6kNtUSbcxSiUGlqzwUJYyOR4xb6mL4JcZqhsG68Kwt6HwcUtJhr1Xmso ksUe1XT6TXTMM+xG4C/M0m6YUza3a+JIRiPMRg== Received: by omta-ad1-fd3-101-ca-toronto-1.omtaad1.vcndpyyz.oraclevcn.com (Oracle Communications Messaging Server 8.1.0.1.20221212 64bit (built Dec 12 2022)) with ESMTPS id <0ROM007DDQO3UD70@omta-ad1-fd3-101-ca-toronto-1.omtaad1.vcndpyyz.oraclevcn.com> for linux-wireless@vger.kernel.org; Tue, 17 Jan 2023 12:28:51 +0000 (GMT) From: Peter Lafreniere To: kvalo@kernel.org Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, Peter Lafreniere Subject: Re: [PATCH] wifi: rsi: Avoid defines prefixed with CONFIG Date: Tue, 17 Jan 2023 07:28:38 -0500 Message-id: <20230117122838.5006-1-peter@n8pjl.ca> X-Mailer: git-send-email 2.39.0 In-reply-to: <87mt6h8xu7.fsf@kernel.org> References: <87mt6h8xu7.fsf@kernel.org> MIME-version: 1.0 Content-transfer-encoding: 8bit Reporting-Meta: AAFB26/OsDs3HpaqMgyiQ+gVr10Eu3gsJyXSTiaqp0dYs2WEvkjae9Bo+cOYXsN/ U1yayjDbJGkvjRRxA5O5uC24CUPlfHp7L49dx42FbM1X4KQ5HVUg/GDr5y7mEcQe 8h9upfgSs5S1YeCWLyn4MZo7XDkxEBMStGk13qMQoWJaQIaeLc50bD+rQ6LxXpjs OJoLPdPerTmN6DK2I8brClx30niUWgDE5bccR5B6WJP8+0bUPeKClGqoKat7W5A0 XuPgdUNoVFlE6u6uSTgWcgS6eQvsTx4JssQJkqs8qFRU2lTgdvTQG3aISJ/4hVY0 OfYyEKgDU9XaeWBAVXwH+UDrbqHRs/SRLFWedC8OVpjBJ4RRAAZ3KbPQBfO6fnYh RBV5/vu+KUibHz3ASIO+jllmS8QXePeUMVzICVqiXE3VDvZ9BeIMgzkfuUMG+jo2 dw== X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org That would work better, but to me it seems odd to have one define with a prefix and the others without. I could change them all, but that seems like excessive churn for the very minor 'issue' that it fixes. After rereadig rsi_load_9113_firmware(), it seems like just dropping the CONFIG_ would be a reasonable change that doesn't affect readability. Cheers, Peter