Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6fb9fc37203bab5082603caf4b4fbecdd3241541.camel@sipsolutions.net>
Subject: Re: [PATCH net-next] wifi: ipw2200: use strscpy() to instead of
 strncpy()
From:   Johannes Berg <johannes@sipsolutions.net>
To:     yang.yang29@zte.com.cn, stas.yakovlev@gmail.com
Cc:     kvalo@kernel.org, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        xu.panda@zte.com.cn
Date:   Tue, 17 Jan 2023 22:23:25 +0100
In-Reply-To: <202212231056165052797@zte.com.cn>
References: <202212231056165052797@zte.com.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2022-12-23 at 10:56 +0800, yang.yang29@zte.com.cn wrote:
> From: Xu Panda <xu.panda@zte.com.cn>
>=20
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL-terminated strings.
>=20
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> Signed-off-by: Yang Yang <yang.yang29@zte.com>
> ---
>  drivers/net/wireless/intel/ipw2x00/ipw2200.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/w=
ireless/intel/ipw2x00/ipw2200.c
> index ca802af8cddc..6656cea496b1 100644
> --- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c
> +++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
> @@ -1483,8 +1483,7 @@ static ssize_t scan_age_store(struct device *d, str=
uct device_attribute *attr,
>=20
>  	IPW_DEBUG_INFO("enter\n");
>=20
> -	strncpy(buffer, buf, len);
> -	buffer[len] =3D 0;
> +	strncpy(buffer, buf, len + 1);
>=20

Ummm?

But anyway - why bother ... ancient drivers, clearly OK code.

johannes