Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp5848497rwb; Tue, 17 Jan 2023 20:17:07 -0800 (PST) X-Google-Smtp-Source: AMrXdXulMoq4p5VKMNkpH+4u9Pv8F+i383zN1gHr1J+C4wvLZ64RKq2fkShqfSZybCwvzJQu677x X-Received: by 2002:a17:90a:430f:b0:229:46f0:6f71 with SMTP id q15-20020a17090a430f00b0022946f06f71mr5521318pjg.45.1674015427419; Tue, 17 Jan 2023 20:17:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674015427; cv=none; d=google.com; s=arc-20160816; b=gTPWmEbshdS1a9+NlV/8eOM2a3k6DXzKr83VfP6iHOomG5kMhXVlMQkLYbuhmxf3US X52V1rS0LBsPM9WU0o4etEbKV8SEsWbiJnhs6sydH++jcTaTeWefp4dYzKtcdT+nbaM9 tIcr/p24olRb70pu7kRJU5Yt+JOYorkHNE67roSa4MyAtXE4nuaQWf7mPqyEkYio9wJz tBHAsNROnq7IQHCBtMwQdGy0IuyHc/9B6csdNE1t/oDEkkB33Foaf1YZvXLuFji9VS6N /jWfY99mNK47z3qOizv2A04cDW+unsOv+Mb8YdwLJUUF+zMSCzsWTv61dE8cdbEoAWJx oDQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=1bwEIoHhV5/+DHKASeOOx9kK/e+WgdmgsaTYHUw2Qfc=; b=Y5Lv9V+GYUqC2YfmrfPG8m6s+6F9PMtq+BScl3DxyD2oc11lFJXZvYpLv5M5GUg9hD EsNt5OnC0DCPE4xGUs6tHwxugZPIY7Du4QxY6myuZkuu5Sv427BfGn5ZFhM62Gq9Zq94 OrxYGKiP4L3J/xfn1xprLjkSTLcwTZ8zWQd5DbEWr+658MoC0+Awix3TzYuXRuYfTHJ7 Z3vRy57Q0pPieN66oXQKo7NPCTpBQF5/KB7gBVOxf2SLg32/31sVwFpkD+ooxuOaWWvF 8I+ndwCo6FRHEdo5PJ7oOjIoPgGBYvprLtcwwngNdntPJX5NNz6GbxDEs8P2GIjBWpJ2 zlNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IpuE3NTa; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pi2-20020a17090b1e4200b002294419acc9si922479pjb.107.2023.01.17.20.16.55; Tue, 17 Jan 2023 20:17:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IpuE3NTa; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229598AbjARD7j (ORCPT + 63 others); Tue, 17 Jan 2023 22:59:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbjARD7i (ORCPT ); Tue, 17 Jan 2023 22:59:38 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E346222F4; Tue, 17 Jan 2023 19:59:37 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 38EEAB81B05; Wed, 18 Jan 2023 03:59:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50372C433EF; Wed, 18 Jan 2023 03:59:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674014374; bh=Fl8kayFc9jqoIFP9l+2qRSeRmkqifuW10BFKmmYkmig=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=IpuE3NTaEXM/SpZnwC07DQpUI/0oy2iSk7uYqBuik0rHeFZj04Zwl18FwleeihYVj A2gn/ypuwmyoH531wFVereYiAZfLh+94SWxyjD60x9SLD9uSNXFXrqxRa1USo8sOb6 Vl4jMEAG11TaC+JIlRpIeRLk2MDpfUV8urH718pdKizzH4Cfe4uDu0f2FpJmUHGKE0 +nUGhqWfj2i5TxUzh9Af5H64aX6RpDj4EYijwbR5xTi94X45QTzulfxzX+3qHsXVzA uekyTkbAJcBap/t6YoMOtwyDjAGa2H3ddySq79DbFl3ER9tIVNgm4/wBcxJPoZi4Zn nf/Iy3s8IgZXQ== From: Kalle Valo To: "Alexey V. Vissarionov" Cc: Arend van Spriel , Franky Lin , Hante Meuleman , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alvin =?utf-8?Q?=C5=A0ipraga?= , Chi-hsien Lin , Ahmad Fatoum , Wataru Gohda , Sebastian Andrzej Siewior , Wolfram Sang , Pieter-Paul Giesberts , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] wifi: brcmfmac: Fix allocation size References: <20230117104508.GB12547@altlinux.org> <87o7qxxvyj.fsf@kernel.org> <20230117112141.GB15213@altlinux.org> Date: Wed, 18 Jan 2023 05:59:28 +0200 In-Reply-To: <20230117112141.GB15213@altlinux.org> (Alexey V. Vissarionov's message of "Tue, 17 Jan 2023 14:21:41 +0300") Message-ID: <87fsc88pcv.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org "Alexey V. Vissarionov" writes: > On 2023-01-17 13:05:24 +0200, Kalle Valo wrote: > > >> - buf_size += (max_idx + 1) * sizeof(pkt); > >> + buf_size += (max_idx + 1) * sizeof(struct sk_buff); > > Wouldn't sizeof(*pkt) be better? > > Usually sizeof(type) produces less errors than sizeof(var)... This matter of taste really but FWIW I prefer sizeof(var) as then the type can't be different by accident. And the coding style says something similar, although that's related to memory allocation: https://www.kernel.org/doc/html/latest/process/coding-style.html#allocating-memory -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches