Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp6025621rwb; Tue, 17 Jan 2023 23:32:46 -0800 (PST) X-Google-Smtp-Source: AMrXdXsGwefCLh+zlyEEKAYKW+98O59AhJzoukxktThK+d3HjTEA7zTF6JAlVg15+4FvxMcgkW4+ X-Received: by 2002:a17:90a:2f89:b0:219:6619:848a with SMTP id t9-20020a17090a2f8900b002196619848amr6079265pjd.36.1674027165907; Tue, 17 Jan 2023 23:32:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674027165; cv=none; d=google.com; s=arc-20160816; b=cP5S2b+m6Z8ZYswU9ctV3+pvWPY2QMTaEnpeVRQIMzlo2nQDLTgHt2WIz9X6sSIE/1 6UL/5k/hWheZ7hzxdkD/3KzJ9C1LkhdxsPzG8Byyb8DmlkECyF7nXV/v1YULHiO3vGct XMy4jDRbazMdFCy+mDz4otmjmaNUVcYp0zrNoLFbzk2vZzGuB/hrv/3rXahgaH0wqtI2 ysojKZYsROjv5f8QumEuDpEDD5fgOnTMEfSiRO1CNMz1J8FIorpUcPBj+RxN2C4Tc3Ct dj7lTRy4QmOUpMma78tGu3IKpHlXE+F9CXrJER01ctJjo+AWBQu86nxpDIK7Yn7Pgy3F Frhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=MoOqQjEIwZ/LAw70PZz1JRbE2tH2szfOLM3ApJ+J58A=; b=Fpao2b4l1kp2AXLPzfE8qt/xkwZ+KuoUhYMU4Qj5ZV3rY6q/2Ek/dj9IA5nZceuAOK XYNFCBcA66d/OjQS1n9jHpEiMaueho+9P1S7LwENZc0ZwzXpgUnuYugPK1jsoKR/sxwt S/zlx8gNil/mfos6SPm8T9pT+n6IRez9+iIq+K1zFCQZDNZcEDujKcEm1owaKz1hp+xt znhvmzY5Ed/03tKhadKiMbv7qofnfYJy/TbgLY1hNMptZl3vkacTygMlQCf6jNhO7HEc 9OqIHr7bo6cqtWNRRGL0IsGrR175cd3N2GmRP1OneQAlY4XDIJLfkNNFrivGdq1IsVOs UIqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rkbSW35T; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bt11-20020a17090af00b00b002270cec0ebasi1298490pjb.63.2023.01.17.23.32.38; Tue, 17 Jan 2023 23:32:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rkbSW35T; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230048AbjARHJZ (ORCPT + 63 others); Wed, 18 Jan 2023 02:09:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229770AbjARHIz (ORCPT ); Wed, 18 Jan 2023 02:08:55 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6DDF6C571; Tue, 17 Jan 2023 22:35:53 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 65BD2B81B43; Wed, 18 Jan 2023 06:35:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A980BC433EF; Wed, 18 Jan 2023 06:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674023722; bh=UsZhg3e/FoLkTU5R3hvEWS8a+d3s1oq7ddrZA6/R5ZE=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=rkbSW35Tf5XzQltEqJK1XK2bgCeGOIyt0k25tAaDauGymr2QAEfDKzjLEafnEjg+m 6E6ixXFJP/Y9sgiaTtGf2DqLLGJvJFj9/1i0m0cjW/wco172djAyy4Ov+NqBuKxiWO 3y3GLZwo09QopS8eFVfnls35rdFuHELzhIEiDBmYLZhMHzZkFXxFyWqWS9RavSE1O/ vseCn2qrZgium/eGEvupTLm9c3qnLKVKNl9SKV28uDZzYhQWBQTyxYlEsDFRWZE2ZF bCoCim3jlVYAqNW1Z+2eZil5DZqMu0Zg5Iaf/v2cX0+NbguVqGFS15L4/ze4n2WPgN czNXfcZZ5tRKg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] wifi: ath11k: Fix memory leak in ath11k_peer_rx_frag_setup From: Kalle Valo In-Reply-To: <20230102081142.3937570-1-linmq006@gmail.com> References: <20230102081142.3937570-1-linmq006@gmail.com> To: Miaoqian Lin Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Manikanta Pubbisetty , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linmq006@gmail.com User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <167402371642.24104.14787775190477327666.kvalo@kernel.org> Date: Wed, 18 Jan 2023 06:35:19 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Miaoqian Lin wrote: > crypto_alloc_shash() allocates resources, which should be released by > crypto_free_shash(). When ath11k_peer_find() fails, there has memory > leak. Add missing crypto_free_shash() to fix this. > > Fixes: 243874c64c81 ("ath11k: handle RX fragments") > Signed-off-by: Miaoqian Lin > Reviewed-by: Leon Romanovsky > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. ed3f83b3459a wifi: ath11k: Fix memory leak in ath11k_peer_rx_frag_setup -- https://patchwork.kernel.org/project/linux-wireless/patch/20230102081142.3937570-1-linmq006@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches