Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp6048535rwb; Tue, 17 Jan 2023 23:57:58 -0800 (PST) X-Google-Smtp-Source: AMrXdXsOo+OeYp5MSlBxxu923VexKcGZNEkWP9qcbCahRllHsqIvy/nqFs/ueVamipCgw4b8DIMR X-Received: by 2002:a17:902:f610:b0:192:7363:f6c7 with SMTP id n16-20020a170902f61000b001927363f6c7mr7724999plg.37.1674028677991; Tue, 17 Jan 2023 23:57:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674028677; cv=none; d=google.com; s=arc-20160816; b=EGp1NyalQk0e7dblnkG89E+n1rqSA+w+Q0Uyn04oo7vkQC+/AJ+3HUIsv/MF0vIBHr SiXfaOQAC4DrRxlIqkB61nNUcl1pTZd6gztSzfK39UXhY/BBFj6HBUgXO6FDYZk+ENna Pa70q2FyCiFr1lfxlRMxGpoS//eOPZZJTW73xK1NGkKmfRtF/w5FgBvs4yCFLTHK+Dpd Waa9xKRnP+L9zXUGclkNUr1VxzB2vU1496sscOqxdQtZjbU/xv4Ua5QtS5/ftGdPgKcJ LohTfrdW0m80L8DvvzKOfg5A8jTjWC1GbgWwWbp9VZoSmpnR90AVD8fBc4ZTOaEQtGd3 +qbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=3QQoXf7VUs62IGp4UYBshoqobAbu1H/Lu6aspZ8PbhI=; b=Vt6ICJdjxX4AE5CFi2NOcl4j8CvKKqZ6uZYgECAM1W4C+apNJpgoRqPIomifkCodiM sPMOCQ+ShI+/TWplALaMbBwbMN6WB4QNu9Caxwdp1TSw2jLFJq4+14EHOmX+PhtNPqgT olNpHJVEBPXzZauua04uNBadKMyDpgrEpW/+ItF+bo5NL8n3DpY3MSThvzq0xUeyfLEM AWSe6B2dfoj9bv8BlnfD8CPE9ZJnp8YU2EG3nVY/nT2WrEInohmXW6tv7qjwVtINEoC2 ylNnWwPc5FT0YKYpPEB6Z/Q/LOUhfTNPEoHdiUw5RW1kvGaS0w2Rw/L1uvqDn1uE4qi4 /e+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Tzox7rRO; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t6-20020a170902e84600b001948a15d138si11759762plg.139.2023.01.17.23.57.47; Tue, 17 Jan 2023 23:57:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Tzox7rRO; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229919AbjARHyt (ORCPT + 63 others); Wed, 18 Jan 2023 02:54:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229656AbjARHxc (ORCPT ); Wed, 18 Jan 2023 02:53:32 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95D9558663; Tue, 17 Jan 2023 23:28:56 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 30863615CE; Wed, 18 Jan 2023 07:28:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 948FAC433EF; Wed, 18 Jan 2023 07:28:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674026935; bh=b84KPZ2F9X2F1bkJ0Ejdn0pRUACRucNe2ZVO2IOrpWo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Tzox7rROXdvBicsZM0UYTGyoqU9D/06FaYJvhL+qqGSHKVOzOIjMYYb8YxqCn1W5z 3bmmBrxxnbCciq+QqCHXDWZ8HnH0nXcm7wt5Jlpq6xqKvTxPmX9lpQyVN6FyPf4TmQ 9XLDds6UFL3MeP/IT/7L2wSs7+uFHKpHQRhJZzVERLJAluimTUvm9fjnOujWXkzu9A kcQ5uhtgwUlmZCoeccZZX4XmzfIvNNyMv5QSYrYxubvsMPhsd0H017e1QfrbryIu6w ++q0ofUMbd429nSGVxCmwGjlcf2Os7i+nVHqPLpKzpkKLkUx7CaIaZXkr+FNK7Fbai S2bW2UYaR6FUw== From: Kalle Valo To: Peter Lafreniere Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] wifi: rsi: Avoid defines prefixed with CONFIG References: <87mt6h8xu7.fsf@kernel.org> <20230117122838.5006-1-peter@n8pjl.ca> Date: Wed, 18 Jan 2023 09:28:51 +0200 In-Reply-To: <20230117122838.5006-1-peter@n8pjl.ca> (Peter Lafreniere's message of "Tue, 17 Jan 2023 07:28:38 -0500") Message-ID: <87bkmwxpvw.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Peter Lafreniere writes: > That would work better, but to me it seems odd to have one define > with a prefix and the others without. I could change them all, but > that seems like excessive churn for the very minor 'issue' that > it fixes. > > After rereadig rsi_load_9113_firmware(), it seems like just dropping > the CONFIG_ would be a reasonable change that doesn't affect readability. Yeah, removing CONFIG_ looks good as well. But please add quotes into your email. We get A LOT of email so having proper quotes is important, otherwise we don't know what you are answering to. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches