Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0ed850ac7d13fc5d40545aff1d59d710374bfcf4.camel@sipsolutions.net>
Subject: Re: [PATCH 6/7] cfg80211: rework nl80211_parse_chandef for 6 GHz
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Aditya Kumar Singh <quic_adisi@quicinc.com>,
        linux-wireless@vger.kernel.org
Date:   Wed, 18 Jan 2023 12:03:21 +0100
In-Reply-To: <20220704102341.5692-7-quic_adisi@quicinc.com>
References: <20220704102341.5692-1-quic_adisi@quicinc.com>
         <20220704102341.5692-7-quic_adisi@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2022-07-04 at 15:53 +0530, Aditya Kumar Singh wrote:
>=20
> +	/* For APs, 6 GHz power mode is taken from the user configured
> +	 * value. However, for clients, power mode is also dependent
> +	 * upon the APs power mode to which this client has associated.
> +	 * Hence for client, need to take power mode of asscoiated AP,


typo - associated

But anyway, were you going to resubmit this with comments from the first
patches addressed?

Honestly I'd also like to see a bit more discussion (in the cover letter
I guess) about the solution with "multiple channel spaces" and all that.
And ideally about alternatives considered - why not for example keep a
single space with flags indicating support for the power mode, etc.

johannes