Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp6681881rwb; Wed, 18 Jan 2023 08:08:17 -0800 (PST) X-Google-Smtp-Source: AMrXdXv+4KIryMRKAzOU/6wZSZXQpIyp7OGYJs68rAqV76HtOqEcsWsaFz1flBcRNwL4btQt1nhu X-Received: by 2002:a17:906:cb89:b0:868:d72f:d106 with SMTP id mf9-20020a170906cb8900b00868d72fd106mr7573312ejb.47.1674058097478; Wed, 18 Jan 2023 08:08:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674058097; cv=none; d=google.com; s=arc-20160816; b=gdkT6Uz/wqQF1nGz4HETm07KK9q6OchGcjki7ga+ormKTIH+IaNpqIU5w7PhOO97Dv NwRDCJ3kxH+XX39VZOiZavrues4F9QdxiPP8ZIBzbjtND1ziwuXDoPz6bwAvepfwaY22 4Z33t5eIRKNs7+Qr39svVebhoaTruGr0hpIotTgnpf1Zidep6CrLLYfwObTTE+9B8/PN jAu8InyE7CGUe0g7p2ZsEM+PIqz1VORoKQW8m+oGBoMfiYMLVIAndm22baHdNSikZlrh raQMyXmoo5r5AV+KALDhAf5eq6RRLUgs0+PBXAQsAtr0Q0i7PPg5IaC/yM5JwbeYmnYt rD9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:to:from :subject:message-id:dkim-signature; bh=iGKuhT8qUdQU9bkT4zASobwQHITRxrTd/34c/v2fk/A=; b=LKY2Tqmj6q/o/Eo062iojS+Qz8dc9aCcFErPnpXFH9BbPgWVlehp6Oc19Dwgrj/f0z P6X37Ti/grcWFjyuCgKe0ssEAHbdXxWRrhboQgobB2KNl9iBp1XHN+qC8cB15uYwDjND iA+H2tt6BSDy/e5+tstZF8Vb48jzkTX56Wsrp3coimNLX04z/MhypLB5LFRxeBm1TBP7 WhxQF5gPB2cGGCqG+yYF7hkMp06YaSivyPJchhNBpAng1sfMuCMFGlJ28+p6tonYD9hg RO+LAB6k97lBPDAIq0kbiLN0kL10B2kCqzggMUcMQl3hjbwltlRNd3DOwqBU/rs4Om7h glmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=d7QEqRNj; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wv4-20020a170907080400b0084ca5f2b837si35755679ejb.676.2023.01.18.08.07.58; Wed, 18 Jan 2023 08:08:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=d7QEqRNj; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229779AbjARQBc (ORCPT + 63 others); Wed, 18 Jan 2023 11:01:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231327AbjARQAE (ORCPT ); Wed, 18 Jan 2023 11:00:04 -0500 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55EE74EC6 for ; Wed, 18 Jan 2023 07:57:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:To:From:Subject:Message-ID:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=iGKuhT8qUdQU9bkT4zASobwQHITRxrTd/34c/v2fk/A=; t=1674057429; x=1675267029; b=d7QEqRNjpq3x7BsyJS2cNDPYzt40xkbm/yIiVVwgtMYH+1Y xgSvpl9igAPoLba50JuqcOGJOeCyeMshnuh8SX9fdq4y5c6tx/kXeotDl4wXIv3s/0QrYlJxa4r3A d7VqpegJXETGig3fBDxQ6cSKZx2ORSL6AxFIkuUZ1ARZdWJr0HcJSEZi2YtWrVaQ8OixnivChoRyF aiqjUUlE3qixEnVY99LHcajEyh8bBbxasxh3JK8W/z8yuODtH/JZZTiulF3d8K7twkU0zhLuqpUn5 JAfET8cKvHiUILn8Fa6uKULOCd4j6BwqmNFR+jFqNN+axsetRtdAvOkaPndQYFKg==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1pIAoF-005ei9-0Q; Wed, 18 Jan 2023 16:57:07 +0100 Message-ID: <0b42cfb9f0effce61b33c41ec9067b3747fade5c.camel@sipsolutions.net> Subject: Re: [PATCH v7 2/3] nl80211: additional processing in NL80211_CMD_SET_BEACON From: Johannes Berg To: Aloka Dixit , linux-wireless@vger.kernel.org Date: Wed, 18 Jan 2023 16:57:06 +0100 In-Reply-To: <20221109214720.6097-3-quic_alokad@quicinc.com> References: <20221109214720.6097-1-quic_alokad@quicinc.com> <20221109214720.6097-3-quic_alokad@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 2022-11-09 at 13:47 -0800, Aloka Dixit wrote: > FILS discovery and unsolicited broadcast probe response transmissions > are configured as part of NL80211_CMD_START_AP, however both stop > after userspace uses the NL80211_CMD_SET_BEACON command as these > attributes are not processed in that command. That seems odd. Why would that *stop*? Nothing in the driver should actually update it to _remove_ it during change_beacon()? Are you sure you didn't mean to "just" say "however both cannot be updated as these attributes ..."? johannes