Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 18 Jan 2023 17:13:29 +0100
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Shayne Chen <shayne.chen@mediatek.com>
Cc:     Felix Fietkau <nbd@nbd.name>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        Bo Jiao <Bo.Jiao@mediatek.com>,
        linux-mediatek <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH 06/13] wifi: mt76: add EHT rate stats for ethtool
Message-ID: <Y8gaqTqI/un8dgZd@lore-desk>
References: <20230109165731.682-1-shayne.chen@mediatek.com>
 <20230109165731.682-7-shayne.chen@mediatek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="17+pKBupczAMysgX"
Content-Disposition: inline
In-Reply-To: <20230109165731.682-7-shayne.chen@mediatek.com>
Precedence: bulk


--17+pKBupczAMysgX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Add support to get EHT rate stats from ethtool.
> This is the preliminary patch to add EHT support for mt7996.
>=20
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mt76.h        | 2 +-
>  drivers/net/wireless/mediatek/mt76/mt7996/main.c | 6 ++++++
>  2 files changed, 7 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76.h b/drivers/net/wire=
less/mediatek/mt76/mt76.h
> index b3fd3abfdd9f..3d3c68b9e1cf 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt76.h
> @@ -272,7 +272,7 @@ enum mt76_phy_type {
> =20
>  struct mt76_sta_stats {
>  	u64 tx_mode[__MT_PHY_TYPE_MAX];
> -	u64 tx_bw[4];		/* 20, 40, 80, 160 */
> +	u64 tx_bw[5];		/* 20, 40, 80, 160, 320 */

Hi Shayne,

I think this change will break mt7915 ethtool support. In particular it will
break tx_bw for loop in mt76_ethtool_worker().

Regards,
Lorenzo

>  	u64 tx_nss[4];		/* 1, 2, 3, 4 */
>  	u64 tx_mcs[16];		/* mcs idx */
>  	u64 tx_bytes;
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/main.c b/drivers/n=
et/wireless/mediatek/mt76/mt7996/main.c
> index c423b052e4f4..9ea2e1198477 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7996/main.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7996/main.c
> @@ -1084,10 +1084,14 @@ static const char mt7996_gstrings_stats[][ETH_GST=
RING_LEN] =3D {
>  	"v_tx_mode_he_ext_su",
>  	"v_tx_mode_he_tb",
>  	"v_tx_mode_he_mu",
> +	"v_tx_mode_eht_su",
> +	"v_tx_mode_eht_trig",
> +	"v_tx_mode_eht_mu",
>  	"v_tx_bw_20",
>  	"v_tx_bw_40",
>  	"v_tx_bw_80",
>  	"v_tx_bw_160",
> +	"v_tx_bw_320",
>  	"v_tx_mcs_0",
>  	"v_tx_mcs_1",
>  	"v_tx_mcs_2",
> @@ -1100,6 +1104,8 @@ static const char mt7996_gstrings_stats[][ETH_GSTRI=
NG_LEN] =3D {
>  	"v_tx_mcs_9",
>  	"v_tx_mcs_10",
>  	"v_tx_mcs_11",
> +	"v_tx_mcs_12",
> +	"v_tx_mcs_13",
>  };
> =20
>  #define MT7996_SSTATS_LEN ARRAY_SIZE(mt7996_gstrings_stats)
> --=20
> 2.25.1
>=20

--17+pKBupczAMysgX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCY8gaqQAKCRA6cBh0uS2t
rCjbAP9gamsCGrHCI7lRONjPAy30luSazvHeHFDCzXXxtwIDygEA7kk0hRdlqvZe
feHpFAfzcmJZ+zzwlnA6XyJkvOhfAgo=
=bmhD
-----END PGP SIGNATURE-----

--17+pKBupczAMysgX--