Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b3c6f2839c2092250ad8f6cd1e6ed4cb9d7a3ce5.camel@sipsolutions.net>
Subject: Re: [PATCH] bitfield: add FIELD_PREP_CONST()
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Alexander Lobakin <alexandr.lobakin@intel.com>
Cc:     linux-wireless@vger.kernel.org
Date:   Wed, 18 Jan 2023 20:41:11 +0100
In-Reply-To: <5ade37de-2582-9e80-b99f-01aab13d991c@intel.com>
References: <20230118142652.53f20593504b.Iaeea0aee77a6493d70e573b4aa55c91c00e01e4b@changeid>
         <92209c00-7fcf-1592-e97c-f49e7734fdfc@intel.com>
         <3fe52061d5d9e3701f598add5c64f8b3583c31df.camel@sipsolutions.net>
         <b2c78f45-345b-e3ec-20b1-9d18ee0c9f98@intel.com>
         <8b955e4d859aafdf42f1a11f37ddf2a5e47c2610.camel@sipsolutions.net>
         <5ade37de-2582-9e80-b99f-01aab13d991c@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-01-18 at 19:21 +0100, Alexander Lobakin wrote:
> > So you could pull out the expression "((n) & ((n) - 1)) !=3D 0" from al=
l
> > four of these, but it doesn't feel worth it.
>=20
> Aaaah I see.
>=20
> __BUILD_BUG_ON_NOT_POWER_OF_2_ZERO() then? :D
>=20
> (mostly joking and not sure it's worth it, up to you)
>=20

Yeah exactly! I briefly considered but didn't really want to touch
build_bug.h for basically nothing :)

johannes