Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp85730rwb; Wed, 18 Jan 2023 14:32:57 -0800 (PST) X-Google-Smtp-Source: AMrXdXs/bHoIXaCMUjL88Q9GRGz4EAkwCb9ikndQ51xQ4IYKOVIwVwQJUtXGpHzKUmaqtbBFDFv+ X-Received: by 2002:aa7:8286:0:b0:582:b7a7:de13 with SMTP id s6-20020aa78286000000b00582b7a7de13mr9568418pfm.10.1674081177202; Wed, 18 Jan 2023 14:32:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674081177; cv=none; d=google.com; s=arc-20160816; b=BgFVuWo0mSsh595FHqCc1ihPg791rCeoiUXZ9oqMtAhaXyOYgOveRsX6suhnS8bRHi 0zniltMbPZlmwjbTWPXO2a23d4u4fzgdPcKgNlk6en+T2+nSsJbCtGQtyLEMEwI9Y0bm hLRacTuE7xvV8qZznDxFAbUNr5Ux16e4mzE01lA92Uld8ct01w8/OjJe+s02QoDAILlC ds0xoMErfdqzTYFT60nX4awR/VcLEBF2WaFHHU6nZnsj5liN4EA7fHklB4M1HanEnH/1 AIZo4yOFtIRWLvBsjsSXTEQhnum9I4mE81IVS30gwBmWkmjSjo9NXNvOESbzMm96NqOI 1rsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=33VsmywiSt+1st7fYNpGyVnbGYmu+R+zUG3V8a3kz1c=; b=KbdJrX3GFhixerXcASZc88hAaqbxPPvUqiTpQM50TtA6QdX3SxE+HGDhZZL3wj0c5W gcvwAVHbKZNAtcPQ6oygnasLvGA6glsI0P+H3JOVNBqd3z2sy0ogxAxb2STpwBsgJ3XD qU3Ed0on9neNyNuQRdNarjRPjYoGZt3TRWMtG+TdT714ukDaXaOdZgU+dJJhRuxfhjVw BhSWgEodqAH2KSxnROS746wQu29NF26IcqG3hk/vkgEQMTTqDFi+PT6R4M3+qt0G0VlO 11wFFwKntvHFrqfiKdeKNa6gfiMx9TxD3Mw2RVE4st2687/96pK/9QRWgN9gA/gTDHUh LJcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Bq8T0f17; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r7-20020a63e507000000b004b2c5ff33d5si30689880pgh.58.2023.01.18.14.32.42; Wed, 18 Jan 2023 14:32:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Bq8T0f17; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229540AbjARWYv (ORCPT + 63 others); Wed, 18 Jan 2023 17:24:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjARWYu (ORCPT ); Wed, 18 Jan 2023 17:24:50 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 763CC63081 for ; Wed, 18 Jan 2023 14:24:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674080640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=33VsmywiSt+1st7fYNpGyVnbGYmu+R+zUG3V8a3kz1c=; b=Bq8T0f17vYl7nruS9KxO4mbAycH4C8baK/BuZ7NWOgnyOPvcjuxBbEsYDc7/qRrLh/XPU1 yYXy2s0mW5ttl41DAmSnaJwD76k5TPll9875UTcgdBaqRMjh/lrh9P+UsTjovzPPUad/5b JSv8OpE+odgwqXqxWuBdHHb+wuBXEh0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-458-O1uVURL7MGKMhmobAY-30w-1; Wed, 18 Jan 2023 17:23:58 -0500 X-MC-Unique: O1uVURL7MGKMhmobAY-30w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1272A2A5956F; Wed, 18 Jan 2023 22:23:56 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3759A2026D4B; Wed, 18 Jan 2023 22:23:55 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: To: Lukas Wunner Cc: dhowells@redhat.com, Johannes Berg , linux-wireless@vger.kernel.org Subject: Re: [PATCH] wifi: cfg80211: Deduplicate certificate loading MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2700983.1674080634.1@warthog.procyon.org.uk> Date: Wed, 18 Jan 2023 22:23:54 +0000 Message-ID: <2700984.1674080634@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Lukas Wunner wrote: > load_keys_from_buffer() in net/wireless/reg.c duplicates > x509_load_certificate_list() in crypto/asymmetric_keys/x509_loader.c > for no apparent reason. > > Deduplicate it. No functional change intended. > > Signed-off-by: Lukas Wunner > Cc: David Howells Acked-by: David Howells