Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\))
Subject: Re: [RFC v2 4/6] mac80211: add utility function for tx_rate -
 rate_info conversion
From:   Jonas Jelonek <jelonek.jonas@gmail.com>
In-Reply-To: <64731257b957f50b0f66e4d2fcd8c24dea8d70ff.camel@sipsolutions.net>
Date:   Thu, 19 Jan 2023 12:31:03 +0100
Cc:     linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>
Content-Transfer-Encoding: quoted-printable
Message-Id: <9AE44A41-6357-4F3A-BF75-8E3B0A381E9B@gmail.com>
References: <20220920104032.496697-1-jelonek.jonas@gmail.com>
 <20220920104032.496697-5-jelonek.jonas@gmail.com>
 <64731257b957f50b0f66e4d2fcd8c24dea8d70ff.camel@sipsolutions.net>
To:     Johannes Berg <johannes@sipsolutions.net>
Precedence: bulk


> On 12. Jan 2023, at 11:26, Johannes Berg <johannes@sipsolutions.net> =
wrote:
>=20
>> +void ieee80211_rate_get_rate_info(const struct ieee80211_tx_rate =
*rate,
>> +						struct wiphy *wiphy, u8 =
band,
>> + 						struct rate_info =
*rate_info)
>> +{
>> + 	memset(rate_info, 0, sizeof(struct rate_info));
>> +
>> + 	if (rate->flags & IEEE80211_TX_RC_MCS) { /* 802.11n */
>> + 		rate_info->flags |=3D RATE_INFO_FLAGS_MCS;
>> + 		rate_info->mcs =3D rate->idx;
>> + 	} else if (rate->flags & IEEE80211_TX_RC_VHT_MCS) { /* 802.11ac =
*/
>> + 		rate_info->flags |=3D RATE_INFO_FLAGS_VHT_MCS;
>> + 		rate_info->mcs =3D ieee80211_rate_get_vht_mcs(rate);
>> + 		rate_info->nss =3D ieee80211_rate_get_vht_nss(rate);
>> + 	} else { /* 802.11a/b/g */
>=20
> what about HE/EHT?

ieee80211_tx_rate uses an s8 for rate/MCS index, so only up to VHT rates =
fit in there.
For rates above VHT, rate_info is needed, thus are are no HE/EHT rates =
occuring in
ieee80211_tx_rate. Same applies to your comment on the hwsim conversion.

Jonas=