Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b7eb7ae9ae1b24ae7f6ac5fc8cb50ed3840a61f5.camel@sipsolutions.net>
Subject: Re: [RFC 2/4] wifi: cfg80211: RU puncturing bitmap
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Muna Sinada <quic_msinada@quicinc.com>
Cc:     linux-wireless@vger.kernel.org,
        Aloka Dixit <quic_alokad@quicinc.com>
Date:   Thu, 19 Jan 2023 16:34:04 +0100
In-Reply-To: <1670006154-6092-3-git-send-email-quic_msinada@quicinc.com>
References: <1670006154-6092-1-git-send-email-quic_msinada@quicinc.com>
         <1670006154-6092-3-git-send-email-quic_msinada@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2022-12-02 at 10:35 -0800, Muna Sinada wrote:
>=20
> + * @ru_punct_bitmap: RU puncturing bitmap. Each bit represents a 20 MHz =
channel
> + *	with lowest bit corresponding to the lowest frequency. Bit set to 1
> + *	indicates that the channel is punctured, otherwise the channel is act=
ive
> + * @ru_punct_bitmap_supp_he: Indicates whether RU puncturing bitmap vali=
dation
> + *	should include OFDMA bitmaps.

Why _supp_he and not _supp_ofdma? Is it restricted to HE? What about
EHT?

I'm also not really sure what that kernel-doc means for the _supp_he
part?


Also this patch is basically empty - please squash appropriately.

johannes