Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0b77bad5-f55c-73d5-7cd0-dfed57871f25@quicinc.com>
Date:   Thu, 19 Jan 2023 16:42:31 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [RFC 3/4] wifi: nl80211: validate RU puncturing bitmap
To:     Johannes Berg <johannes@sipsolutions.net>,
        Muna Sinada <quic_msinada@quicinc.com>
CC:     <linux-wireless@vger.kernel.org>
References: <1670006154-6092-1-git-send-email-quic_msinada@quicinc.com>
 <1670006154-6092-4-git-send-email-quic_msinada@quicinc.com>
 <3df39d4f2e2e64bd3899cfbe7bade547e54330f7.camel@sipsolutions.net>
Content-Language: en-US
From:   Aloka Dixit <quic_alokad@quicinc.com>
In-Reply-To: <3df39d4f2e2e64bd3899cfbe7bade547e54330f7.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/19/2023 7:37 AM, Johannes Berg wrote:
> Frankly I'm not happy for this to be stuck into set_interface() like
> that - can we add it to set_channel() only or something? At least there
> should be too? And read it only if the channel is actually touched? This
> feels very ad-hoc.
> 
> johannes

Hi Johannes,

I will work on these comments.

Secondly, this RFC uses ieee80211_valid_disable_subchannel_bitmap() 
defined in following RFC you sent:
https://patchwork.kernel.org/project/linux-wireless/patch/20220325140859.e48bf244f157.I3547481d49f958389f59dfeba3fcc75e72b0aa6e@changeid/

Is there is any plan for the next version?
If not, I can move the validation function defined in cfg80211 to 
mac80211 from the following patch-set:
https://patchwork.kernel.org/project/linux-wireless/patch/20220214223051.3610-3-quic_alokad@quicinc.com/

You had asked me about exporting this during the review as well.

Please let me know so that I can incorporate accordingly.
Thanks.