Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 19 Jan 2023 19:36:15 +0100
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     Nicolas Cavallari <nicolas.cavallari@green-communications.fr>,
        Rameshkumar Sundaram <quic_ramess@quicinc.com>,
        ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] nl80211: add support to enable/disable bss color
 collision detection
Message-ID: <Y8mNn18XeUcEjLWe@lore-desk>
References: <20221226083328.29051-1-quic_ramess@quicinc.com>
 <20221226083328.29051-2-quic_ramess@quicinc.com>
 <74c57dc34af10537f98f5bb9b6ce80e5676e09b0.camel@sipsolutions.net>
 <1609a645-3e23-7e37-9aa1-94f970e481e2@green-communications.fr>
 <2a2332211b2ca9daa968a3644006f5c9e0c88a00.camel@sipsolutions.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="CjbjeWRTJw133AO1"
Content-Disposition: inline
In-Reply-To: <2a2332211b2ca9daa968a3644006f5c9e0c88a00.camel@sipsolutions.net>
Precedence: bulk


--CjbjeWRTJw133AO1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> On Thu, 2023-01-19 at 15:52 +0100, Nicolas Cavallari wrote:
> >=20
> > This may not be related, but the software color collision detection=20
> > sends a netlink message for every colliding frame and it can hose up th=
e=20
> > system if the other network is very active.
> >=20
> > Also, cfg80211_bss_color_notify() complains that the wdev lock isn't he=
ld.
>=20
> Yay.
>=20
> Lorenzo can you take a look at that?

It seems fine to me, I am just wondering if we need to forward the info to =
the
hw (if it supports hw color collision detection) if we just flip
collision_detection_enabled field in ieee80211_change_beacon().
What do you think?

Regards,
Lorenzo

>=20
> johannes

--CjbjeWRTJw133AO1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCY8mNnwAKCRA6cBh0uS2t
rF1WAQDn0Cpq8dywuxhT9abbxS+UcqmUcLXe506jMOtSe0qEgQD+ISFZ0CY7xESa
GESufErqWNSQzx08Bf2a03IvzoCfIg8=
=9anP
-----END PGP SIGNATURE-----

--CjbjeWRTJw133AO1--