Date:   Mon, 23 Jan 2023 09:06:03 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Doug Brown <doug@schmorgal.com>
Cc:     Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Dan Williams <dcbw@redhat.com>,
        libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [PATCH v4 0/4] wifi: libertas: IE handling fixes
Message-ID: <Y84/69P2y84WVWok@corigine.com>
References: <20230123053132.30710-1-doug@schmorgal.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230123053132.30710-1-doug@schmorgal.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Md7Xk4NNympgDlaJ5/DN5lcJu7vRBnl5ExkFJCCK/4/6essD585LU+sAmAAS?=
 =?us-ascii?Q?JpPcrkJRktbVRFAZ8Y9bN+3lhqFMIyBg+BztTmgHlJGv9U1iLXYr4BmAMYi3?=
 =?us-ascii?Q?07GHh5tEqQ8UrCO8ZOSUxcFY/ltzIpsAlQ9IxPSpLwxE3estlAkjLlgU7JRB?=
 =?us-ascii?Q?WloRJxHXq1g+bsuT+axq2HEaUYEfaOOPc2PlQZE9cifaN1fG4CIk2YHThfEe?=
 =?us-ascii?Q?oqMEYOIH7SPRLJ4nZlo0JlQ0wJ2l8hohU6YgOrOjBERhi4FTc87Xl2zYiW3F?=
 =?us-ascii?Q?hBlSQoV5bh5ghdeZNf7LbRlSE1a2PrqaDU19tl/QeGu7o2t6xin51uYgyBUD?=
 =?us-ascii?Q?dJ1eJljvj7AnSvZdVAM45P8GY1eypuALwHwtKT7Q8SpnleyBcIde5bsgCgDc?=
 =?us-ascii?Q?8jrYdCH1EorkrPMBe+W03icbAwFye3uYIIdaYx5r4PS2RkfKZPTuRd4lQrXe?=
 =?us-ascii?Q?sH/EsNqWgd1vcPIimymjN/nyYMIh/OfD7P/SxDA5LNgXsufkys09NQ52IA7p?=
 =?us-ascii?Q?4AOpgcq/V8Oh2Hy4MMq4v6jEyLGy4fW4YaGUQIWFGKSfovs57zyFRyOo+BhY?=
 =?us-ascii?Q?o4IfEbRCEF/GShz7hhgcMBWXSHuTxoIc9IYoVLzjpZOpPj2QQfKbF9HfA92F?=
 =?us-ascii?Q?8VqR1K2qtSD3acDCVSbtcJF6HSXMO9P0il1Xh+Y1EQ2LTJgJaMaqyO2bkxqI?=
 =?us-ascii?Q?YQb+YprG4n1RbIy4fPRajY2VdjeMzIk9ctCzhCyX/tN7WbhQJ5nhuv7cRE6b?=
 =?us-ascii?Q?y/ssGFNIFio7aBm5sCsMPV6gOWNFdiJ9jAlZXsPoBX9b1ooOdWppVhs/bPmV?=
 =?us-ascii?Q?xCd/p+GwWGRG7ezDWnBerJgIZPQAdL0O2fODjsVOd9ldPp7rUiMm8eNGj1Xe?=
 =?us-ascii?Q?PyNITDMtZiOsdIlHMv8oPOvTVHBnz+dqa8wCr3yRy3k8n6hxaa9C4T8n6jZ/?=
 =?us-ascii?Q?jGBCV9Ax/S4HTOCNi7SDkQN2VXAWP75gtSQFyV046z/1PEMbj7wn+/tnhIBT?=
 =?us-ascii?Q?Gvuaa1jctDwU0Ox8dgzlu/j/W8yDtPGTdtxE+PPlVP9NWDTt0Qbq/817BVME?=
 =?us-ascii?Q?2r5yDF096NJKW3/6DDvtOZOIUOc7mckRCzaEI7dL9u/REioVuvKNTmu4EoUN?=
 =?us-ascii?Q?VAlnGrJxuSFBJhnaC8673fEv94Rg+BdkMBe9I0a+eGt0bkG3ThTcRj30h676?=
 =?us-ascii?Q?tpQNIK+FEgpzmsJsEL8Qfa7zL3hCZDp5WVSJYlcYqnCAhKlApwVJRamznmM7?=
 =?us-ascii?Q?CFhu3Uakz0mwIS1xbnMrX2qgTNNAmFURiDn+5kXl7bToSbTmreuasU59+PT+?=
 =?us-ascii?Q?3S16ZEASmZNuBKIFRDV6TBJi4nT56WkmVhUnTB/PkFwAOCFVpwWsBw82tM5B?=
 =?us-ascii?Q?5puuAp3w6LTYf20QVZQagVWyFW8abLDtF3aCVemQPfrFaS3ZdUMXH2bCXM+c?=
 =?us-ascii?Q?Z2EikkMNsxQysejh4lVP8sjwgGH75MzbprvNmbtEomvkaeMQQuJ2dW4x/gel?=
 =?us-ascii?Q?kpG7ERE2Gdi2EisuU5FVWtqns8SjPw/lg0KOFemWGhm0tDl6U+GPDddFmNlK?=
 =?us-ascii?Q?bTHHn5faHbR3SzMq897Yi/g6gIqbJt/TsMRfYwihdEaotYehNC+g7m6W+a9p?=
 =?us-ascii?Q?HM073WsdOzyRBWKOWizVtYbVKePkNthPslHT0iBazbOkIscIEhuR+4p5bItV?=
 =?us-ascii?Q?ST9ijQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7565fb55-39a9-4065-aad4-08dafd18afad
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2023 08:06:09.6344
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hwHXQrN60tcGRihHLdUDnsRFTMo/NQIWyiaVZWtcUrSGl6LoFGgPYhm3iOAt0IxKAu1479ZiYl+mOEWVBJ5sSCKqR0P0XVLxVqGJ1/zs33c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR13MB5372
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Sun, Jan 22, 2023 at 09:31:28PM -0800, Doug Brown wrote:
> This series implements two fixes for the libertas driver that restore
> compatibility with modern wpa_supplicant versions, and adds (or at least
> improves) support for WPS in the process.
> 
> 1) Better handling of the RSN/WPA IE in association requests:
>    The previous logic was always just grabbing the first one, and didn't
>    handle multiple IEs properly, which wpa_supplicant adds nowadays.
> 
> 2) Support for IEs in scan requests:
>    Modern wpa_supplicant always adds an "extended capabilities" IE,
>    which violates max_scan_ie_len in this driver. Go ahead and allow
>    scan IEs, and handle WPS based on the info that Dan provided.
> 
> These changes have been tested on a Marvell PXA168-based device with a
> Marvell 88W8686 Wi-Fi chipset. I've confirmed that with these changes
> applied, modern wpa_supplicant versions connect properly and WPS also
> works correctly (tested with "wpa_cli -i wlan0 wps_pbc any").

Thanks,

this looks good to me. So, FWIIW,

Reviewed-by: Simon Horman <simon.horman@corigine.com>