Message-ID: <debfeadf-1a5a-6913-ba24-c6733930f63c@quicinc.com>
Date:   Mon, 23 Jan 2023 18:01:22 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] wifi: ath11k: Add tx ack signal support for mgmt packets
Content-Language: en-US
To:     Kalle Valo <kvalo@kernel.org>
CC:     <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
        Abinaya Kalaiselvan <quic_akalaise@quicinc.com>
References: <20221219053844.4084486-1-quic_mkenna@quicinc.com>
 <87fsc8xsgl.fsf@kernel.org>
From:   Maharaja Kennadyrajan <quic_mkenna@quicinc.com>
In-Reply-To: <87fsc8xsgl.fsf@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/18/2023 12:03 PM, Kalle Valo wrote:
> Maharaja Kennadyrajan <quic_mkenna@quicinc.com> writes:
>
>> From: Abinaya Kalaiselvan <quic_akalaise@quicinc.com>
>>
>> Add support to notify tx ack signal values for mgmt
>> packets to userspace through NL interface.
>>
>> Advertise NL80211_EXT_FEATURE_ACK_SIGNAL_SUPPORT flag
>> to enable this feature and it will be used for data
>> packets as well.
>>
>> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1
>>
>> Signed-off-by: Abinaya Kalaiselvan <quic_akalaise@quicinc.com>
>> Signed-off-by: Maharaja Kennadyrajan <quic_mkenna@quicinc.com>
> [...]
>
>> --- a/drivers/net/wireless/ath/ath11k/wmi.h
>> +++ b/drivers/net/wireless/ath/ath11k/wmi.h
>> @@ -2309,6 +2309,7 @@ struct wmi_init_cmd {
>>   } __packed;
>>   
>>   #define WMI_RSRC_CFG_FLAG1_BSS_CHANNEL_INFO_64 BIT(5)
>> +#define WMI_RSRC_CFG_FLAG1_ACK_RSSI BIT(18)
>>   
>>   struct wmi_resource_config {
>>   	u32 tlv_header;
>> @@ -4541,6 +4542,8 @@ struct wmi_mgmt_tx_compl_event {
>>   	u32 desc_id;
>>   	u32 status;
>>   	u32 pdev_id;
>> +	u32 ppdu_id;
>> +	u32 ack_rssi;
>>   } __packed;
> Adding these two fields increases the minimum length for
> WMI_TAG_MGMT_TX_COMPL_EVENT:
>
> 	[WMI_TAG_MGMT_TX_COMPL_EVENT]
> 		= { .min_len = sizeof(struct wmi_mgmt_tx_compl_event) },
>
> If we have a firmware version which doesn't include ppdu_id and ack_rssi
> in WMI_TAG_MGMT_TX_COMPL_EVENT ath11k will drop those events. Not sure
> what to do.
>
> Is it certain that all ath11k firmware versions have ppdu_id and
> ack_rssi? Or should handle so in ath11k that ppdu_id and ack_rssi can be
> optional in the event?

[Maha]: All ath11k firmware versions have ppdu_id and ack_rssi. So, 
there won't be issue

with minimum length for this event.