Message-ID: <6a67f821-759e-aac5-abf3-d2234c3bd6aa@quicinc.com>
Date:   Mon, 23 Jan 2023 10:28:09 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [RFC 3/4] wifi: nl80211: validate RU puncturing bitmap
To:     Johannes Berg <johannes@sipsolutions.net>,
        Muna Sinada <quic_msinada@quicinc.com>
CC:     <linux-wireless@vger.kernel.org>
References: <1670006154-6092-1-git-send-email-quic_msinada@quicinc.com>
 <1670006154-6092-4-git-send-email-quic_msinada@quicinc.com>
 <3df39d4f2e2e64bd3899cfbe7bade547e54330f7.camel@sipsolutions.net>
 <0b77bad5-f55c-73d5-7cd0-dfed57871f25@quicinc.com>
 <1a063de0aba4a6e2bcf5cacaa661ca8b73c1ffad.camel@sipsolutions.net>
Content-Language: en-US
From:   Aloka Dixit <quic_alokad@quicinc.com>
In-Reply-To: <1a063de0aba4a6e2bcf5cacaa661ca8b73c1ffad.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/20/2023 1:20 AM, Johannes Berg wrote:
> Hi Aloka,
> 
>> Secondly, this RFC uses ieee80211_valid_disable_subchannel_bitmap()
>> defined in following RFC you sent:
>> https://patchwork.kernel.org/project/linux-wireless/patch/20220325140859.e48bf244f157.I3547481d49f958389f59dfeba3fcc75e72b0aa6e@changeid/
> 
> Yes, I saw that.
> 
>> Is there is any plan for the next version?
> 
> Am I correct that by basing your work here on top of that, you're OK
> with that being included, and we've concluded the discussion about where
> and how the puncturing bitmap should be stored? This patchset was an
> RFC, I'm personally happy with the design, but really also want to hear
> your opinion and perspective on it.
> 
> 
> Anyway if that's the case then I'll go and resubmit the patch - we also
> made some more fixes to it since, I think. I'm not sure I'll get to it
> today, but I'll do it soon.
> 
> johannes

Yes, we are okay with the bitmap being part of the bss_conf/link_conf.
Please send the new version with fixes as soon as you can, I'm still 
looking into your comments regarding the design Muna sent.