Message-ID: <758384602b93da0f242ee5d82847a1b4ab102b91.camel@sipsolutions.net>
Subject: Re: [PATCH next] wifi: nl80211: emit CMD_START_AP on multicast
 group when an AP is started
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Alvin =?UTF-8?Q?=C5=A0ipraga?= <ALSI@bang-olufsen.dk>
Cc:     Alvin =?UTF-8?Q?=C5=A0ipraga?= <alvin@pqrs.dk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date:   Tue, 24 Jan 2023 10:26:41 +0100
In-Reply-To: <20230121130717.l5ynezk4rug7fypb@bang-olufsen.dk>
References: <20221209152836.1667196-1-alvin@pqrs.dk>
         <c7eac35785bf672b3b9da45c41baa4149a632daa.camel@sipsolutions.net>
         <20230121130717.l5ynezk4rug7fypb@bang-olufsen.dk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

Hi,

> > Seems like you should include the link ID or something?
>=20
> Thanks for your review, you are quite right. I didn't give much thought
> to MLO as I am not too familiar with it. Is something like the below
> what you are looking for?

Yes, that looks good.

> Speaking of which: I drew inspiration from nl80211_send_ap_stopped()
> which see also doesn't include the link ID. Would you like me to include
> a second patch in v2 which adds the link ID to that function along the
> same lines?

Maybe have that as a separate patch, but yeah, good idea - thanks for
looking!

johannes