Message-ID: <57e98e3b6542e20a7a0a4b974a13cdf67b834f26.camel@redhat.com>
Subject: Re: [PATCH v4 0/4] wifi: libertas: IE handling fixes
From:   Dan Williams <dcbw@redhat.com>
To:     Doug Brown <doug@schmorgal.com>, Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Cc:     Simon Horman <simon.horman@corigine.com>,
        libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org
Date:   Tue, 24 Jan 2023 12:24:56 -0600
In-Reply-To: <20230123053132.30710-1-doug@schmorgal.com>
References: <20230123053132.30710-1-doug@schmorgal.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Sun, 2023-01-22 at 21:31 -0800, Doug Brown wrote:
> This series implements two fixes for the libertas driver that restore
> compatibility with modern wpa_supplicant versions, and adds (or at
> least
> improves) support for WPS in the process.
>=20
> 1) Better handling of the RSN/WPA IE in association requests:
> =C2=A0=C2=A0 The previous logic was always just grabbing the first one, a=
nd
> didn't
> =C2=A0=C2=A0 handle multiple IEs properly, which wpa_supplicant adds nowa=
days.
>=20
> 2) Support for IEs in scan requests:
> =C2=A0=C2=A0 Modern wpa_supplicant always adds an "extended capabilities"=
 IE,
> =C2=A0=C2=A0 which violates max_scan_ie_len in this driver. Go ahead and =
allow
> =C2=A0=C2=A0 scan IEs, and handle WPS based on the info that Dan provided=
.
>=20
> These changes have been tested on a Marvell PXA168-based device with
> a
> Marvell 88W8686 Wi-Fi chipset. I've confirmed that with these changes
> applied, modern wpa_supplicant versions connect properly and WPS also
> works correctly (tested with "wpa_cli -i wlan0 wps_pbc any").

Tested with a usb8388 (fw 9.34.3p23), x86, wpa_supplicant 2.10.
Scanning and connecting to a WPA2 AP works. Doesn't panic when I pull
the dongle out. Ship it!

Reviewed-by: Dan Williams <dcbw@redhat.com>
Tested-by: Dan Williams <dcbw@redhat.com>

Dan

>=20
> Changes since V3:
> - Do more extensive code style fixes suggested by Ping-Ke Shih
>=20
> Changes since V2:
> - Add missing cpu_to_le16 as suggested by Simon Horman
>=20
> Changes since V1 (which was a single patch linked here [1]):
>=20
> - Switch to cfg80211_find_*_elem when looking for specific IEs,
> =C2=A0 resulting in cleaner/safer code.
> - Use mrvl_ie_data struct for cleaner manipulation of TLV buffer, and
> =C2=A0 fix capitalization of the "data" member to avoid checkpatch
> warnings.
> - Implement idea suggested by Dan to change max_scan_ie_len to be
> =C2=A0 nonzero and enable WPS support in probe requests while we're at it=
.
> - Remove "Fixes:" tag; I'm not sure if it's still appropriate or not
> =C2=A0 with it depending on the capitalization fix.
> - Clarify comments.
>=20
> [1]
> https://lore.kernel.org/all/20230102234714.169831-1-doug@schmorgal.com/
>=20
> Doug Brown (4):
> =C2=A0 wifi: libertas: fix code style in Marvell structs
> =C2=A0 wifi: libertas: only add RSN/WPA IE in lbs_add_wpa_tlv
> =C2=A0 wifi: libertas: add new TLV type for WPS enrollee IE
> =C2=A0 wifi: libertas: add support for WPS enrollee IE in probe requests
>=20
> =C2=A0drivers/net/wireless/marvell/libertas/cfg.c=C2=A0=C2=A0 | 76 ++++++=
+++++++++--
> --
> =C2=A0drivers/net/wireless/marvell/libertas/types.h | 21 ++---
> =C2=A02 files changed, 74 insertions(+), 23 deletions(-)
>=20