Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BB95C636CD for ; Mon, 30 Jan 2023 13:37:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236282AbjA3Nhf (ORCPT ); Mon, 30 Jan 2023 08:37:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235869AbjA3Nhd (ORCPT ); Mon, 30 Jan 2023 08:37:33 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 686B039295; Mon, 30 Jan 2023 05:37:30 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C63C860FFA; Mon, 30 Jan 2023 13:37:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADFAFC4339E; Mon, 30 Jan 2023 13:37:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675085849; bh=xVUKXbUIi6xLEiIYm55wmvp+1ETe+NKrYKfL39iZqjk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZWhdZxNByqgLSw9ZeTKMACA5jYn4ulj+8bWVDJshVzFGSC7BiIUszBGzEsXnrQBZN Y6mR3+pWmnNoRqLRkrZHQtJj9e/k4IryR/3jnJpRPLqP9UWarUAFRJ83gj7OeH0Nbf x+vu/g0l6yctoaZ/DAaPY/eJt8CD6euDYXXQyicQ= Date: Mon, 30 Jan 2023 14:37:26 +0100 From: Greg Kroah-Hartman To: =?utf-8?B?0JbQsNC90LTQsNGA0L7QstC40Ycg0J3QuNC60LjRgtCwINCY0LPQvtGA0LU=?= =?utf-8?B?0LLQuNGH?= Cc: "stable@vger.kernel.org" , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Kalle Valo , "David S. Miller" , Jakub Kicinski , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Alexey Khoroshilov , "lvc-project@linuxtesting.org" Subject: Re: [PATCH 5.10 1/1] mt76: fix mt7615_init_tx_queues() return value Message-ID: References: <20230130123655.86339-1-n.zhandarovich@fintech.ru> <20230130123655.86339-2-n.zhandarovich@fintech.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, Jan 30, 2023 at 01:27:26PM +0000, Жандарович Никита Игоревич wrote: > > What is the git commit id of this upstream? > > > > And I can't apply this as-is for the obvious reason it would mess up the > > changelog, how did you create this? > > > > confused, > > > > greg k-h > > Commit in question is b671da33d1c5973f90f098ff66a91953691df582 > upstream. I wasn't certain it makes sense to backport the whole patch > as only a small portion of it pertains to the fault at question. What is the "fault"? And why not take the whole thing? What's wrong with that? We almost always want to take whatever is in Linus's tree because when we do not, we almost always cause bugs or other problems (later merge issues.) So always take the original fix please. thanks, greg k-h