From:   Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
To:     Douglas Anderson <dianders@chromium.org>,
        "ath11k@lists.infradead.org" <ath11k@lists.infradead.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
CC:     Kalle Valo <kvalo@kernel.org>,
        "junyuu@chromium.org" <junyuu@chromium.org>,
        Youghandhar Chintala <quic_youghand@quicinc.com>,
        Jiri Slaby <jirislaby@kernel.org>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Nick Kossifidis <mickflemm@gmail.com>,
        Abhinav Kumar <quic_abhinavk@quicinc.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Manikanta Pubbisetty <quic_mpubbise@quicinc.com>,
        Marc Zyngier <maz@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH v2 1/2] wifi: ath11k: Use platform_get_irq() to get the
 interrupt
Thread-Topic: [PATCH v2 1/2] wifi: ath11k: Use platform_get_irq() to get the
 interrupt
Thread-Index: AQHZNl3qWoWF4hqjYEqUe1oE70EsXa66jOTQ
Date:   Wed, 1 Feb 2023 20:39:35 +0000
Message-ID: <OSZPR01MB701949307C9DFB0E064B74ACAAD19@OSZPR01MB7019.jpnprd01.prod.outlook.com>
References: <20230201084131.v2.1.I69cf3d56c97098287fe3a70084ee515098390b70@changeid>
In-Reply-To: <20230201084131.v2.1.I69cf3d56c97098287fe3a70084ee515098390b70@changeid>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9+ZtP1yvCbquV6r5DZxrfYt6q0FZGZxjXvNLLFZ9UP0QzM/Px11l4FzgSR2h?=
 =?us-ascii?Q?8u8NXJnrFWLL1f5PSV89NA91zjksnt1dBJZ2EXRPjPVoZsVkbrjL1wI3eWTC?=
 =?us-ascii?Q?wSjqX2cob/mKF5hPctRxgKOqLftDJPHqJKDPjpaOPzRMBizKzJkPryfqqjFR?=
 =?us-ascii?Q?X9Qm32aJX7CC5WsmAM90pgeR7PRxXiY2lOUFzaQmMzSMShO93ov6egy9Gwc2?=
 =?us-ascii?Q?lZWfw7HUj+LRPh6gI5u0cIHceTOYhsbxQ1rI+cXGS2mAT1r+zimKgwLL++jc?=
 =?us-ascii?Q?lnDsWZ9VO3L6yDywJKMB6pnpnTsWM/IB7cXjBeOkIMNhaDStMdsDSmtp5w80?=
 =?us-ascii?Q?E+ZDqXOU7A4hAS/wtgNsU7MmhShNGWR1/3VNEqaOHY8lblRDrbyG+JLN0d1C?=
 =?us-ascii?Q?eq7XKA+1TafNiZFJFg1C5tHSE5j7NleEf0xXbgd9U29xDe6L1GIyy7n473sp?=
 =?us-ascii?Q?ro7Va37nsVEN7uXcaHTk4EFsZJgY39WIEjeSBJnkzl4mwg7FlilD84Xr+Zez?=
 =?us-ascii?Q?ZSRs7HV+x8n1zE7u+GvFQlYasVoWWoD5Jc5opul+6fvOe1lvG3hrWyEypxR+?=
 =?us-ascii?Q?qoptdjk4A1GYgngDdnzIsEW+7FBjFSSOuETBBFCSEBiMlkKPYg1WbglqNmB3?=
 =?us-ascii?Q?3TMTSqJVeroVaMB8kM23BzCYa8W6YRRug7VumXGGp1+lQNnagI1wW8RECfnt?=
 =?us-ascii?Q?XK0S/amiJzx8efj9z3QFuF0bj8dp9N/E60ZuDAVGyc4+FlVtWRRCG+hBaB2B?=
 =?us-ascii?Q?q99FM+/b6JZ5/f01IexeCo7rZmUdVP/+a0qa4dCrmDdogZk20O1QVCkrP7ib?=
 =?us-ascii?Q?W24Io4/W8MsQZ6ZKdydsuJQLUKQVQc9MVJEjsbKdKip71nqkAvqwOTKGJkr6?=
 =?us-ascii?Q?ZneeTaISf55zmN/wRoog9HFk50cVXD1Z2Lv2kPcw8Yox9wa/+nQaS8bQOmSm?=
 =?us-ascii?Q?xJ42b+XykS2f8a1/ILWVgAZr6urbTFDMLZhBvLWO18YMhZwakrgVYOR12qbU?=
 =?us-ascii?Q?SMDqKl7XhZfLoGS2IrMS5pS+E3NaiVS5fUMZvjVaTeFJjMMGYhrkYESa8b9s?=
 =?us-ascii?Q?xilPOUUA3dThRZ4bQOn47Nz6iXNlkTFdUEs1HgPf8XB5YbrROWQXuKg46053?=
 =?us-ascii?Q?9HV2hgYlGBRI6lo+e9d/7gfXdVx9PAgpfHLyrtdWAuOGkqLYlr8x+Xq4dFnm?=
 =?us-ascii?Q?H0PbgsmfXMT6x2HFR6tV9a1t/r3fcbp5O7PEq+b81adJxccwRTQV0IoFR/o1?=
 =?us-ascii?Q?o77rkI93xsDBCiMnxwWMpNdy2wL6OkHcnWG3MrqTNamysPcFq0rW7DphlX/P?=
 =?us-ascii?Q?Yf5vbxXYuoxitP2paT8ICexDEqh0/cAi7yJBRUAeoFWiacK6ga+f0HGm8ukQ?=
 =?us-ascii?Q?omdQzLPTc4oeuVgDoDmnWSLuVpe9SaD5aF5P2IFkQlGsNPrQ2p9dsCRkq+Wr?=
 =?us-ascii?Q?9tiPL/NHRoT5d8vFD8WF7pX35zPJ+adphzt4hJ56C4uIKe6nkvxAfSLGxqNa?=
 =?us-ascii?Q?7CWPsPpuR1C4aS8wfv8wY/2lunU8UzOovuz4M2XcYHaEKsEvIB18CKD6mkKg?=
 =?us-ascii?Q?p8NARP5jYsqysy/y6SYOFTUbKyhlC+6HOaqiusxb8nAxUUQSyeV8okbzGn8H?=
 =?us-ascii?Q?ERsg6SRd62S8d3y+zeQh0b4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OSZPR01MB7019.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6cede696-077e-4ff1-20eb-08db04946e07
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2023 20:39:35.0532
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dwv1znjG1lHETeQ08DKSLmxgfL1jvQEPbElMN9QJKZ6S6Cn8+J1IGbhnCrMHvd/3MNqB0dMV4fHn6DUFf+cwvRgouBqLdVR+0pnWxhQ3UcdumnAUZMwaB0c9rI3V9GwZ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB6228
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Hi Douglas,

Thank you for the patch.

> As of commit a1a2b7125e10 ("of/platform: Drop static setup of IRQ resourc=
e from DT core"), we need to
> use platform_get_irq() instead of
> platform_get_resource() to get our IRQs because
> platform_get_resource() simply won't get them anymore.
>=20
> This was already fixed in several other Atheros WiFi drivers, apparently =
in response to Zeal Robot
> reports. An example of another fix is commit 9503a1fc123d ("ath9k: Use pl=
atform_get_irq() to get the
> interrupt"). ath11k seems to have been missed in this effort, though.
>=20
> Without this change, WiFi wasn't coming up on my Qualcomm sc7280-based ha=
rdware. Specifically,
> "platform_get_resource(pdev, IORESOURCE_IRQ, i)" was failing even for i=
=3D0.
>=20
> Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1
>=20
> Fixes: a1a2b7125e10 ("of/platform: Drop static setup of IRQ resource from=
 DT core")
> Fixes: 00402f49d26f ("ath11k: Add support for WCN6750 device")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Tested-by: Jun Yu <junyuu@chromium.org>
> ---
>=20
> Changes in v2:
> - Update commit message and point to patch that broke us (Jonas)
>=20
>  drivers/net/wireless/ath/ath11k/ahb.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Unrelated to this patch, I think you need to call dma_unamp_resource() in t=
he error path?

Cheers,
Prabhakar
=20
> diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless=
/ath/ath11k/ahb.c
> index d34a4d6325b2..f70a119bb5c8 100644
> --- a/drivers/net/wireless/ath/ath11k/ahb.c
> +++ b/drivers/net/wireless/ath/ath11k/ahb.c
> @@ -859,11 +859,11 @@ static int ath11k_ahb_setup_msi_resources(struct at=
h11k_base *ab)
>  	ab->pci.msi.ep_base_data =3D int_prop + 32;
>=20
>  	for (i =3D 0; i < ab->pci.msi.config->total_vectors; i++) {
> -		res =3D platform_get_resource(pdev, IORESOURCE_IRQ, i);
> -		if (!res)
> -			return -ENODEV;
> +		ret =3D platform_get_irq(pdev, i);
> +		if (ret < 0)
> +			return ret;
>=20
> -		ab->pci.msi.irqs[i] =3D res->start;
> +		ab->pci.msi.irqs[i] =3D ret;
>  	}
>=20
>  	set_bit(ATH11K_FLAG_MULTI_MSI_VECTORS, &ab->dev_flags);
> --
> 2.39.1.456.gfc5497dd1b-goog