From:   Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
To:     Douglas Anderson <dianders@chromium.org>,
        "ath11k@lists.infradead.org" <ath11k@lists.infradead.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
CC:     Kalle Valo <kvalo@kernel.org>,
        "junyuu@chromium.org" <junyuu@chromium.org>,
        Youghandhar Chintala <quic_youghand@quicinc.com>,
        Jiri Slaby <jirislaby@kernel.org>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Nick Kossifidis <mickflemm@gmail.com>,
        Abhinav Kumar <quic_abhinavk@quicinc.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Marc Zyngier <maz@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH v2 2/2] wifi: ath5k: Use platform_get_irq() to get the
 interrupt
Thread-Topic: [PATCH v2 2/2] wifi: ath5k: Use platform_get_irq() to get the
 interrupt
Thread-Index: AQHZNl3rzcyQcazGiUq1wUEKfZMPgq66jmCw
Date:   Wed, 1 Feb 2023 20:44:35 +0000
Message-ID: <OSZPR01MB7019B1D2D0367354BF03F5D3AAD19@OSZPR01MB7019.jpnprd01.prod.outlook.com>
References: <20230201084131.v2.1.I69cf3d56c97098287fe3a70084ee515098390b70@changeid>
 <20230201084131.v2.2.Ic4f8542b0588d7eb4bc6e322d4af3d2064e84ff0@changeid>
In-Reply-To: <20230201084131.v2.2.Ic4f8542b0588d7eb4bc6e322d4af3d2064e84ff0@changeid>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9J2DTYCC8Du7zQ0cti5J3+CRgMW4mVy4pQWbA5v19mIYSYTz9XxwdtlEzaXh?=
 =?us-ascii?Q?qbTiYCP3vzeKzPD+V55XK2ra5qWQYc7eCyzBEMwVWEMbCMrYhIC8Kf1Yiry5?=
 =?us-ascii?Q?KZegXuwX3+cl4DgVgPjkgqWejfOvk/S4rBJE2i6nxg+hkzu6VjeYBDJ0b/Uk?=
 =?us-ascii?Q?wcUlju9we3/msSBCk2VNlVI58Gec9tTgtJhkyVGiz6Uj45fL511dNm9iO3BM?=
 =?us-ascii?Q?uSD6ntDcPUKNJM81OuWIxkwuI70DjsBmwkcGtL2//WZGuvc+j0A/3rgGYDuT?=
 =?us-ascii?Q?eQjOA6Lgn/FYd2NeRyGclpibDrPEpFkGyoMjFfO1CYNkUaU2raEwl+k+Slnc?=
 =?us-ascii?Q?/6YxT1TPzZwJrKfczOFN7gDRH9xFn7py+5gmsIKpvavgkKduv/XhnqA5uVTQ?=
 =?us-ascii?Q?wxMEtkzuCIKoBYFkPfDHMNLQcRpTDGAE2atLtyA09b0OJs6SdKYrOPc/OF7b?=
 =?us-ascii?Q?sqxML0dmjj5cBk88Y0UP+H3SrwrkVcxDDO9gOq3xaITtVxVUIs8rWKOAvbFe?=
 =?us-ascii?Q?7fLF3eWBM9h34bvZ6JOYbtz10C8WnXX+L6eiMV61MATs8y/e5g3Yg8wXTBLF?=
 =?us-ascii?Q?Kb6pb6UZhTnlisHV22TzuHhpvGbTn7NzcFetFBsWHzqZjOP3EwJX25vCilcu?=
 =?us-ascii?Q?dBXAaeOBnbAzKH5B9IuyYnyPmOAr5mKWYhucOHP8oDCJ4fX51gjYhFDqnhAr?=
 =?us-ascii?Q?vb1Q74JjS7WJxjSux12LA743wmP407BeSYklDGkGLG93Tps+uWhUl1Aww3wC?=
 =?us-ascii?Q?L6wDKFKZcydxIQ6EvEBksHd3GGrKpF8Sn8QEPDnw2ZavkOQPqRPLtK/xBs+d?=
 =?us-ascii?Q?UiXWGxiyg98eQzN+YkTNyqHImzg1+K+rqcTq/J5cXZ8OnuF3OlzYf7sEvi2F?=
 =?us-ascii?Q?0ug334BmM3V/3gqjyA9nAWtri9ExifiVY4bnbcz+Er9XVhZx9iEPVwvhxBgk?=
 =?us-ascii?Q?UZZllhH0UmvaSVWs+SVW8Em8ngAZC8cJwKDoKFZl2RWQ5K0sJtckW3reswm9?=
 =?us-ascii?Q?6VHBbKT1sY3rr5I7VYpdLBBBncpBKrZKFSgJjOAarClmku8hA1H/umgMhw43?=
 =?us-ascii?Q?eOPQWRa8/uYE9ab1+bugCtqZhFWep1cTTqFiofnJwNt8zjiah4+7Q1qQuMFn?=
 =?us-ascii?Q?2JrEeQvHofpVmzrbJGtN+yn/SbrqXJ92FlGXLMNi7W7PuAFTqu84er0fjeNU?=
 =?us-ascii?Q?6FzbBmLfDMrS6xbEj8iq0ROZ7Gva22atoJnUEfSoAGmzGBtfN6e0mjM7+4ND?=
 =?us-ascii?Q?24wmP3dpRLgGrmxnhL59y6giAaxuQ3Zm5H14h/pKJZuQ97kVzn4YlkOXQJrf?=
 =?us-ascii?Q?Ex2XCsQjfL6f9G7ZV18sqc4CfZ3k3j84E+IguNEte4esANtTYrxvvSePvkxK?=
 =?us-ascii?Q?F2sFK5tcG04290ar5NzobWMT1uD2sodfHMTnwOGB5YM+GrZ7csTVl4bKb0h1?=
 =?us-ascii?Q?ofmaNpGD5OIMGxveGiqoI3fhnMnXinVDOi1ZZGWRPcp/E0itls7QRuz7abYG?=
 =?us-ascii?Q?DutLTObFvHhLz8znuttT/yZsyccX/+ZYteX60dm7L7yYGlz135F7uekRNlZg?=
 =?us-ascii?Q?AwueGGTWzj9pcDDjuvd+0HuE/fo22hcxCL0AaM1JIt93p440/QG6X5fUiOf2?=
 =?us-ascii?Q?voPHFU8mKmFlV6SzdK/t+fM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OSZPR01MB7019.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d93f5ff-7c63-49a9-96b2-08db04952119
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2023 20:44:35.4551
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9KoaUx7F5KEl7ZQsTuJHegWvmyOWPiyn4GCsO65M8kQxnHpy+AbfJOV6vKsMa3d8hZp9XlL/pxSPnE6oujR2m0cvGn0JUtgVL3OnlSHLX5NBzDsC0/KrKmdGQuKCQq4A
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB9906
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Hi Douglas,

Thank you for the patch.

> Subject: [PATCH v2 2/2] wifi: ath5k: Use platform_get_irq() to get the in=
terrupt
>=20
> As of commit a1a2b7125e10 ("of/platform: Drop static setup of IRQ resourc=
e from DT core"), we need to
> use platform_get_irq() instead of
> platform_get_resource() to get our IRQs because
> platform_get_resource() simply won't get them anymore.
>=20
> This was already fixed in several other Atheros WiFi drivers, apparently =
in response to Zeal Robot
> reports. An example of another fix is commit 9503a1fc123d ("ath9k: Use pl=
atform_get_irq() to get the
> interrupt"). ath5k seems to have been missed in this effort, though.
>=20
> Fixes: a1a2b7125e10 ("of/platform: Drop static setup of IRQ resource from=
 DT core")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
> I'm not setup to actually test this, but I figured that I might as well g=
o all the way and fix all the
> instances of the same pattern that I found in the ath drivers since the o=
ld call was actually breaking
> me in ath11k. I did at least confirm that the code compiles for me.
>=20
> If folks would rather not land an untested patch like this, though, feel =
free to drop this and just
> land patch #1 as long as that one looks OK.
>=20
> Changes in v2:
> - Update commit message and point to patch that broke us (Jonas)
>=20
>  drivers/net/wireless/ath/ath5k/ahb.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
>=20

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/=
ath/ath5k/ahb.c
> index 2c9cec8b53d9..28a1e5eff204 100644
> --- a/drivers/net/wireless/ath/ath5k/ahb.c
> +++ b/drivers/net/wireless/ath/ath5k/ahb.c
> @@ -113,15 +113,13 @@ static int ath_ahb_probe(struct platform_device *pd=
ev)
>  		goto err_out;
>  	}
>=20
> -	res =3D platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> -	if (res =3D=3D NULL) {
> -		dev_err(&pdev->dev, "no IRQ resource found\n");
> -		ret =3D -ENXIO;
> +	irq =3D platform_get_irq(pdev, 0);
> +	if (irq < 0) {
> +		dev_err(&pdev->dev, "no IRQ resource found: %d\n", irq);
> +		ret =3D irq;
>  		goto err_iounmap;
>  	}
>=20
> -	irq =3D res->start;
> -
>  	hw =3D ieee80211_alloc_hw(sizeof(struct ath5k_hw), &ath5k_hw_ops);
>  	if (hw =3D=3D NULL) {
>  		dev_err(&pdev->dev, "no memory for ieee80211_hw\n");
> --
> 2.39.1.456.gfc5497dd1b-goog