IronPort-SDR: SXRJDolaSo2yG5ml6kxfIX2pqjD5y9o4+vZUdnq+FTsfHh7jMrVTLJn8AgCmsCZeNdGFVwVn/0
 C5zcmPeIspMpXsJ/hYd5Az2WFhXGKl+/SS/U7YU0LzeVZcW93r1ZA9HFKGWdl2WJGmH7wlvlkN
 giPKAOKQA8ICqXxJ/9ROYpCdXoQ9+jBvrWLmnosM/6jHA6FMb/aLjBYK88CqYDt7JQj+dDrQmJ
 k3muUpiF+swl3R8Y0v/oK/FvVIfu/onnRKUtpxsVCZ/DzyPaWLKeSl3iU+zjN7NKVpO2IYdsQB
 jJA=
IronPort-SDR: ro6+q9kS8ABgPI5l106TREhfcf15IvIbgD0FiDCQqiGBnfxzTDuPP1Iq54JQfpHltQXlv6wBOo
 KHEm3EvU16ovNhIsyzum2sZXL4N7dxkn2ENnvPUKXK0bHLzGb3VNZrl5Uk9sa2HFXzZbtbIJM1
 JFmsoW0tWECnG1TSMsCUcvg+4g9JnlzrIYoWPVlVFCCIAGQVyP0gsRYEbJOj0Zkit9K4C8cES/
 m+/PmKAQHqQmp0jmCrG90+/xgj6roUelo0A5z9RJgGOiq0mSo104VMY9eyBsr1PUFgHOQleg0g
 +Vc=
WDCIronportException: Internal
Message-ID: <7cf17a27-13dc-e6b4-c34c-47454239af30@opensource.wdc.com>
Date:   Thu, 2 Feb 2023 06:06:25 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v3] powerpc: macio: Make remove callback of macio driver
 void returned
Content-Language: en-US
To:     Dawei Li <set_pte_at@outlook.com>, mpe@ellerman.id.au
Cc:     npiggin@gmail.com, christophe.leroy@csgroup.eu,
        linuxppc-dev@lists.ozlabs.org, linux-ide@vger.kernel.org,
        netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-serial@vger.kernel.org,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
References: <TYCP286MB232391520CB471E7C8D6EA84CAD19@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <TYCP286MB232391520CB471E7C8D6EA84CAD19@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/1/23 23:36, Dawei Li wrote:
> Commit fc7a6209d571 ("bus: Make remove callback return void") forces
> bus_type::remove be void-returned, it doesn't make much sense for any
> bus based driver implementing remove callbalk to return non-void to
> its caller.
> 
> This change is for macio bus based drivers.
> 
> Signed-off-by: Dawei Li <set_pte_at@outlook.com>
> ---
> v2 -> v3
> - Rebased on latest powerpc/next.
> - cc' to relevant subsysem lists.
> 
> v1 -> v2
> - Revert unneeded changes.
> - Rebased on latest powerpc/next.
> 
> v1
> - https://lore.kernel.org/all/TYCP286MB2323FCDC7ECD87F8D97CB74BCA189@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM/
> ---
>  arch/powerpc/include/asm/macio.h                | 2 +-
>  drivers/ata/pata_macio.c                        | 4 +---
>  drivers/macintosh/rack-meter.c                  | 4 +---
>  drivers/net/ethernet/apple/bmac.c               | 4 +---
>  drivers/net/ethernet/apple/mace.c               | 4 +---
>  drivers/net/wireless/intersil/orinoco/airport.c | 4 +---
>  drivers/scsi/mac53c94.c                         | 5 +----
>  drivers/scsi/mesh.c                             | 5 +----
>  drivers/tty/serial/pmac_zilog.c                 | 7 ++-----
>  sound/aoa/soundbus/i2sbus/core.c                | 4 +---
>  10 files changed, 11 insertions(+), 32 deletions(-)

For the ata bits:

Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

-- 
Damien Le Moal
Western Digital Research