Date:   Sun, 5 Feb 2023 14:39:25 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc:     linux-wireless@vger.kernel.org, tony0620emma@gmail.com,
        kvalo@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Neo Jou <neojou@gmail.com>,
        Jernej Skrabec <jernej.skrabec@gmail.com>, pkshih@realtek.com
Subject: Re: [PATCH v2 3/4] wifi: rtw88: Move enum rtw_tx_queue_type mapping
 code to tx.{c,h}
Message-ID: <Y9+xjd3dXneLjD1i@corigine.com>
References: <20230204233001.1511643-1-martin.blumenstingl@googlemail.com>
 <20230204233001.1511643-4-martin.blumenstingl@googlemail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230204233001.1511643-4-martin.blumenstingl@googlemail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Th18IOQbftAmdu/G9lmMyVPlS9jBEe2xQrrXWb2OuQjcvB1NIvzGSsfcuNzL?=
 =?us-ascii?Q?aDafgHUAsRmL4p/CndIHbNXwwPnPtMB8wNgW1Js3Qz3yKixcYHQD71IF/KF5?=
 =?us-ascii?Q?3NTkOpdExUIOt/KukJPIyjYlGfsdgE8XolQ4BfSAGNhNYmNFlcrNrW0FYHlZ?=
 =?us-ascii?Q?t2/xmln6T/xQ7rW7HMb/VWM3SLUV+ubMtccLkDdRoyrx0Z3+P8K4wU9JJMOk?=
 =?us-ascii?Q?MHYUalwoIdlfoE+EbYSGPCQda9TLJJf7FUUe8fNdnCwAK0MKyC03EiTGmn03?=
 =?us-ascii?Q?oZ44PuVMrB3DG80Nxw5cG/s8e141ZSj5qVIvvgRAZIZZ21JLfnCq4qdpKMZL?=
 =?us-ascii?Q?xuAjo3oW55QVSxSyKt2NUibvZrfrHQMBQr9g9eA5PsDjNbxp1jKmDiQPgz+x?=
 =?us-ascii?Q?P9Mgo4sBw/8yGblxsUNxxRt1phX6yfMF8+sO5ZC1ZGVQEYXCqrf7Atb7O+2e?=
 =?us-ascii?Q?VT0tbi8yV+ClU7Fe0G0LI2Qc+zVA9CkiTZqYK4RaPQsnMwzYHtkzvd6P7Kjx?=
 =?us-ascii?Q?CXqLC5j+0efYVvK56grIJFGvqyzBiG0BgOdSNNz6pQPXqufoPTqjqOAxPJvs?=
 =?us-ascii?Q?55lf23NXIWgVW4dlNs01V7aqhRU2exbobYbO91mEg/WGPCSspk4mvRWgX3dy?=
 =?us-ascii?Q?4Tpy4PjFyuG+mICJQbwshbvuXwHRn20xEX6vZVlOSjleKUTgzBvA1wV84o81?=
 =?us-ascii?Q?AtB3Z48t4ugTxLv1XOBY2RicvrXLnkSBbvbgFCt3vGuhuwufzBs4mWyrvl4W?=
 =?us-ascii?Q?fZWpb6CsAyqaTPPBfNWcO46vb4dperpKHFjTJbxK5hy/9CHfzsbByqkZJgi+?=
 =?us-ascii?Q?vbKTU9KaUQSnjoV+r0/CbgI45z10LqxL9pvGxJIzjKmVS+8uc3NUuputvT5U?=
 =?us-ascii?Q?AEvmKOe/iLIYiPjZYqKAfvX56cyE9JxDg+cY1HW4wpuLYkGvQljsA9m6jDDQ?=
 =?us-ascii?Q?ccXRiUu6DHoOXSPQMPZ+BwHkiyjG6J18H57aBiwJTv/yfS7qG+iBW7cM7JMs?=
 =?us-ascii?Q?cAJwyqRPTGBc0jR44e0WLPK2+XRaXqnxrzT2h+U0gJogmAbt3TwiIBSLJ7GM?=
 =?us-ascii?Q?SNufqbKyHXtKBGAcupBVQA/d3Nv8BmtqKMhN1zWfbY/I2wUOG83OeXj9x8TM?=
 =?us-ascii?Q?rCIZ+22buCsl6DK4R3C/z++Y8vx18dJoYucNGp5RvdhqEJNsEFwLAidzL1lf?=
 =?us-ascii?Q?bLWakGjdesdSg3yGMRni2QEkiFYyIC89LJSwsJ7ImaswXVarIrJ0bDfyPEDx?=
 =?us-ascii?Q?mMRQkkc8dRGxCQr9O9Ef7Iw5tH2roAoIV6E75+ke/WEut+nuqeo5f+jYJ3fC?=
 =?us-ascii?Q?SdFUzrtBHmfC32GBcl8WkcynOBdWly2JMJjrzwyKx5xieubBKn3rcdRdIA1P?=
 =?us-ascii?Q?hRD1spFdbPZf0q0Arv1uGpdkIZ9D2SEgAemHcs/+/+r6XqlamMsTvQL5oxYk?=
 =?us-ascii?Q?ush218FNf9Z+cp/+1bAM1uU81ZHekWhHqr9uwG/p/YydDJUQpSTgk7+faLu3?=
 =?us-ascii?Q?Wy9GxKgslM9TyLOsaqPzRAGYhWAhF7rzes6RAH4jNC2FGYiIxB/Aw0lktZBW?=
 =?us-ascii?Q?XpUwlo0iTOdwhdUTN89vF1T6q+TWUadsRCbZYO2bl+DDh4nOCXKrwmjGUw1s?=
 =?us-ascii?Q?b8wyiw54eFvV3+Qq5/x11cj0RxSxvq/hey9mioxfAiFecj8WmBTTgGa/QIOD?=
 =?us-ascii?Q?a/M7xQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d638421-8253-47a8-2c77-08db077e6947
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2023 13:39:31.8634
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xuLGDjTcaLBLHwyVCKZi/AIY944HUE8KONKCqaH7j7uYzw5UE9l90v9oN0oRRgyCh2qKF17odB9nD/6b1Eof7KN2/tKlukt6PmN9qyWEjUU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB6114
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Sun, Feb 05, 2023 at 12:30:00AM +0100, Martin Blumenstingl wrote:
> This code is not specific to the PCIe bus type but can be re-used by USB
> and SDIO bus types. Move it to tx.{c,h} to avoid code-duplication in the
> future. While here, add checking of the ac argument in
> rtw_tx_ac_to_hwq() so we're not accessing entries beyond the end of the
> array.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>