Message-ID: <bca9544a-1b79-6c17-d52d-cb1869507c88@candelatech.com>
Date:   Tue, 7 Feb 2023 08:49:05 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [RFC PATCH] wifi: mt76: mt7916: Support per-radio configuration
 'firmware' file.
Content-Language: en-US
To:     Kalle Valo <kvalo@kernel.org>, carson.vandegriffe@candelatech.com
Cc:     linux-wireless@vger.kernel.org
References: <20230123175500.3375542-1-carson.vandegriffe@candelatech.com>
 <87lel97bko.fsf@kernel.org>
From:   Ben Greear <greearb@candelatech.com>
Organization: Candela Technologies
In-Reply-To: <87lel97bko.fsf@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/7/23 07:13, Kalle Valo wrote:
> carson.vandegriffe@candelatech.com writes:
> 
>> From: Carson Vandegriffe <carson.vandegriffe@candelatech.com>
>>
>> This lets users specify the upper band that the 7916 radio should use.
>> Upon reboot, the 7916 will be using that upper band.
>>
>> Example config file:
>>
>> myhost@: cat /usr/lib/firmware/mediatek/fwcfg-mmio-0000\:04\:00.0.txt
>>
>> high_band=6
>>
>> Signed-off-by: Carson Vandegriffe <carson.vandegriffe@candelatech.com>
> 
> So this is basically an .ini file with settings for the driver? It's a
> long standing request feature request how wireless drivers should handle
> thatbut there's still no resolution. Having an ASCII parser in the
> driver does not sound a good idea.

It has been many years, no one has offered a better solution that I'm
aware of, so....how long to wait?

Perhaps the parsing logic could move to some helper methods higher in the stack and create a table of
key/value pairs to be used by drivers so that multiple drivers could more easily re-use the parsing
code?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com