Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16FAAC636D4 for ; Mon, 13 Feb 2023 13:45:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230173AbjBMNpd (ORCPT ); Mon, 13 Feb 2023 08:45:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229831AbjBMNpc (ORCPT ); Mon, 13 Feb 2023 08:45:32 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83A948A7E; Mon, 13 Feb 2023 05:45:29 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 93F37CE178F; Mon, 13 Feb 2023 13:45:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4EDEEC433EF; Mon, 13 Feb 2023 13:45:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676295925; bh=Nouoz0V3KyjK32tUvJB+DgTGfTacIM/L0pvOEy6vqCY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=jVh0MJJVi+1/fp6YJ96GyqoKbVAd7tI1aSwMPcL45uCJ/FP5vi4+UkLss+EhGMxrj C9EPZUyFd/hheaRMRj6P9SgVUWtz1ZbqWLedMdtd17iQS7dmGtOmdcR8Dj21QJLzMK XDElvldvm/7g2W/LMU6+i+hwGQNrPUVo3xko5uqgJl3c4NCnTSvd67OQ37rusm0U8P BzdfrTdDjtUZn1pDbtyN292KXs81ZSi+Cv7t1kpR8jGMJXU8OVDzb6o+qgcngZW1TJ JSXg2igwVTF1/YBmc63wiO/cMzKR5n7FFNdj05g44oGF6HFxK0KjOzPXzlByGWa2Ay 3hObGdMf8bPTg== From: Kalle Valo To: Hector Martin Cc: Arend Van Spriel , Aditya Garg , Ping-Ke Shih , Arend van Spriel , Franky Lin , Hante Meuleman , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexander Prutskov , Chi-Hsien Lin , Wright Feng , Ian Lin , Soontak Lee , Joseph chuang , Sven Peter , Alyssa Rosenzweig , Jonas Gorski , asahi@lists.linux.dev, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/4] wifi: brcmfmac: Rename Cypress 89459 to BCM4355 References: <20230210025009.21873-1-marcan@marcan.st> <20230210025009.21873-2-marcan@marcan.st> <0cd45af5812345878faf0dc8fa6b0963@realtek.com> <624c0a20-f4e6-14a5-02a2-eaf7b36e9331@marcan.st> <18640374b38.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> <18640c70048.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> <180b9e56-fbf4-4d98-3d18-a71f3b15e045@marcan.st> Date: Mon, 13 Feb 2023 15:45:17 +0200 In-Reply-To: <180b9e56-fbf4-4d98-3d18-a71f3b15e045@marcan.st> (Hector Martin's message of "Sun, 12 Feb 2023 04:15:52 +0900") Message-ID: <877cwl65n6.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hector Martin writes: >> If Kalle is willing to cleanup the commit message in the current patch you >> are lucky. You are free to ask. Otherwise it should be not too much trouble >> resubmitting it. FWIW I can edit commit logs as long as the changes are simple and the edit instructions are clear, ie. it takes no more than a minute for me to do the edit. > It's even less trouble to just take it as is, since an extra "v2: " in > the commit message doesn't hurt anyone other than those who choose to be > hurt by it. And as I said there's *tons* of commits with a changelog > like this in Linux. It's not uncommon. > > I swear, some maintainers seem to take a perverse delight in making > things as painful as possible for submitters, even when there is > approximately zero benefit to the end result. And I say this as a > maintainer myself. > > Maybe y'all should be the ones feeling lucky that so many people are > willing to put up with all this bullshit to get things upstreamed to > Linux. It's literally the worst open source project to upstream things > to, by a *very long* shot. I'll respin a v4 if I must, but but it's. > Just. This. Kind. Of. Nonsense. Every. Single. Time. And. Every. Single. > Time. It's. Something. Different. This stuff burns people out and > discourages submissions and turns huge numbers of people off from ever > contributing to Linux, and you all need to seriously be aware of that. I understand it's frustrating but please also try understand us maintainers. For example, I have 150 patches in patchwork right now. So it's not easy for us maintainers either, far from it. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches