Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH 1/2 v2] iwl4965: Add missing check for
 create_singlethread_workqueue
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20230209010748.45454-1-jiasheng@iscas.ac.cn>
References: <20230209010748.45454-1-jiasheng@iscas.ac.cn>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     stf_xl@wp.pl, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jiasheng Jiang <jiasheng@iscas.ac.cn>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <167630103649.12830.14676459865773332025.kvalo@kernel.org>
Date:   Mon, 13 Feb 2023 15:10:40 +0000 (UTC)
Precedence: bulk

Jiasheng Jiang <jiasheng@iscas.ac.cn> wrote:

> Add the check for the return value of the create_singlethread_workqueue
> in order to avoid NULL pointer dereference.
> 
> Fixes: b481de9ca074 ("[IWLWIFI]: add iwlwifi wireless drivers")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>

A tip for future submissions, when you submit a new version please submit all
patches from the patchset as v2. It's difficult to pick patches with different
versions.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230209010748.45454-1-jiasheng@iscas.ac.cn/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches