Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1ED7C636CC for ; Mon, 13 Feb 2023 17:18:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229897AbjBMRS5 (ORCPT ); Mon, 13 Feb 2023 12:18:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbjBMRSx (ORCPT ); Mon, 13 Feb 2023 12:18:53 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE2B11A65B for ; Mon, 13 Feb 2023 09:18:52 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 49449611F4 for ; Mon, 13 Feb 2023 17:18:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEA8CC433D2; Mon, 13 Feb 2023 17:18:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676308731; bh=OlDskTA6loInr6LKQH5M8d+VN5enFlP+85pJM3zp5tU=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=ayJtd3QhW/953HMhMMq0Nz7mu7dxRY48l27+G9ENTUCc7zIjTVKZdz4a6541/CgKi tEsURH8Fbl6Ujfds+vXGy0SODYtHSuO8XU0d+N5B6wD9waZxc45GEjV0Wmy8kMKjY7 RgyKKJSlHBB/QWP87MeOXl8y4H5M+8Wav+3p874RVVSxcLxq+gSWD7tBZkhzpJxqwT YmIYaLhXSaVY/QjPIzP5QHyLOQlgiq4p0JDu53Gov5S9lCc6fNB8edRFGRWcqqemlJ 2um95ddIUEDoJlHgy81gziICW83vHI7zBiOkAww/0dsszMretZO5/iiwqSCqsAJKft qGBL8w3ytgLOw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtw89: use passed channel in set_tx_shape_dfir() From: Kalle Valo In-Reply-To: <20230201032057.7349-1-pkshih@realtek.com> References: <20230201032057.7349-1-pkshih@realtek.com> To: Ping-Ke Shih Cc: , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <167630872906.12830.17166929413600795728.kvalo@kernel.org> Date: Mon, 13 Feb 2023 17:18:50 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Ping-Ke Shih wrote: > From: Zong-Zhe Yang > > In path of setting channel and setting TX power, the rtw89_chan instance > to be used is controlled by top and passed down. The set_tx_shape_dfir() > is in path of setting TX power, so it should use the passed rtw89_chan > instead of querying it itself. Otherwise, it might encounter mismatch > between parameters if multi-channel. > > For example, > rtw89_8852ce 0000:04:00.0: set tx shape dfir by unknown ch: 155 on 2GHz > > Signed-off-by: Zong-Zhe Yang > Signed-off-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 764f07f4565d wifi: rtw89: use passed channel in set_tx_shape_dfir() -- https://patchwork.kernel.org/project/linux-wireless/patch/20230201032057.7349-1-pkshih@realtek.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches