Message-ID: <734b2b563c7cb52604aa1c2e5080bfe438f9015c.camel@sipsolutions.net>
Subject: Re: [PATCH 04/15] mac80211: make channel context code MLO-aware
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Wen Gong <quic_wgong@quicinc.com>, linux-wireless@vger.kernel.org,
        ath11k@lists.infradead.org
Date:   Tue, 14 Feb 2023 09:13:46 +0100
In-Reply-To: <0c15bfd6-819e-3e76-391b-f2ab70eb7eba@quicinc.com>
References: <20220601073958.8345-1-johannes@sipsolutions.net>
         <20220601093922.fb3f0f434c72.Icea7e695b0626177e27ab73bc8799202d623cebf@changeid>
         <34121f87-4aa6-7f20-fb1e-4d5b02d06f28@quicinc.com>
         <0e889e3be774aced1813152b18d505c0616fc110.camel@sipsolutions.net>
         <0c15bfd6-819e-3e76-391b-f2ab70eb7eba@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-02-14 at 16:09 +0800, Wen Gong wrote:
> On 2/14/2023 4:04 PM, Johannes Berg wrote:
> > On Tue, 2023-02-14 at 15:57 +0800, Wen Gong wrote:
> > > >    void rate_control_rate_update(struct ieee80211_local *local,
> > > > -				    struct ieee80211_supported_band *sband,
> > > > -				    struct sta_info *sta, u32 changed)
> > > > +			      struct ieee80211_supported_band *sband,
> > > > +			      struct sta_info *sta, unsigned int link_id,
> > > > +			      u32 changed)
> > > >    {
> > > >    	struct rate_control_ref *ref =3D local->rate_ctrl;
> > > >    	struct ieee80211_sta *ista =3D &sta->sta;
> > > >    	void *priv_sta =3D sta->rate_ctrl_priv;
> > > >    	struct ieee80211_chanctx_conf *chanctx_conf;
> > > >   =20
> > > > +	WARN_ON(link_id !=3D 0);
> > > > +
> > > >    	if (ref && ref->ops->rate_update) {
> > > >    		rcu_read_lock();
> > > >   =20
> > > Why link_id must =3D 0 here?
> > >=20
> > The whole software rate scaling hasn't been adjusted for MLO yet.
>=20
> Got it. Thanks.
>=20
> So I guess this WARN_ON will be change later.
>=20

Since you're running into it, you should probably think about addressing
this ... I'm not going to, our hardware doesn't use this code.

johannes