Message-ID: <16d922bd32b30e1a4282dc5941c6fff3b23908ca.camel@sipsolutions.net>
Subject: Re: [PATCH v2] wifi: mac80211: update rx nss for the link sta
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Sriram R <quic_srirrama@quicinc.com>
Cc:     linux-wireless@vger.kernel.org
Date:   Tue, 14 Feb 2023 13:48:27 +0100
In-Reply-To: <20230119221201.24287-1-quic_srirrama@quicinc.com>
References: <20230119221201.24287-1-quic_srirrama@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2023-01-20 at 03:42 +0530, Sriram R wrote:
> Update nss info for the non default link stations
> which gets added during ML assoc when link stations
> gets added. For the default link sta which was added
> during auth time, the nss would be updated in the usual
> flow during set station post assoc once the capabilities
> are available.
>=20
> Signed-off-by: Sriram R <quic_srirrama@quicinc.com>
> ---
> v2: added wifi prefix in commit title
>  net/mac80211/cfg.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>=20
> diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
> index 72df8c708a2d..0fdf92e1428f 100644
> --- a/net/mac80211/cfg.c
> +++ b/net/mac80211/cfg.c
> @@ -1754,6 +1754,15 @@ static int sta_link_apply_parameters(struct ieee80=
211_local *local,
>  						    params->eht_capa_len,
>  						    link_sta);
> =20
> +	/* update nss if not done already for the link sta,
> +	 * for the deflink the nss will be updated once the
> +	 * assoc flag is set through set station. For the
> +	 * non-deflink sta we would reach here only during assoc,
> +	 * so we would have all caps to calculate the nss.
> +	 */
> +	if (&sta->deflink !=3D link_sta)

NACK on that check. Please find a better place, or change the existing
code as well, or something.

johannes