Message-ID: <d9461ebd1a17608f73ef832c60fa7489e358a84e.camel@sipsolutions.net>
Subject: Re: [PATCH 2/2] mac80211: support RNR for EMA AP
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Aloka Dixit <quic_alokad@quicinc.com>,
        linux-wireless@vger.kernel.org
Date:   Tue, 14 Feb 2023 15:33:56 +0100
In-Reply-To: <20221114230416.20192-3-quic_alokad@quicinc.com>
References: <20221114230416.20192-1-quic_alokad@quicinc.com>
         <20221114230416.20192-3-quic_alokad@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2022-11-14 at 15:04 -0800, Aloka Dixit wrote:
>=20
>  	if (params->mbssid_ies) {
>  		mbssid =3D params->mbssid_ies;
>  		size +=3D struct_size(new->mbssid_ies, elem, mbssid->cnt);
> -		size +=3D ieee80211_get_mbssid_beacon_len(mbssid, mbssid->cnt);
> +		if (params->rnr_ies) {
> +			rnr =3D params->rnr_ies;
> +			size +=3D struct_size(new->rnr_ies, elem, rnr->cnt);
> +		}

Is this right? The struct_size() is only the size of the struct, but you
need the size of the elements contained in it here, i.e. the sum of the
.len fields?

johannes