Message-ID: <f5ffcc0b186cf9285e1dedebc8cf47c06d46bbd9.camel@sipsolutions.net>
Subject: Re: [PATCH v10 3/5] cfg80211/mac80211: move interface counting for
 combination check to mac80211
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Wen Gong <quic_wgong@quicinc.com>,
        Luciano Coelho <luciano.coelho@intel.com>,
        linux-wireless@vger.kernel.org
Cc:     michal.kazior@tieto.com, sw@simonwunderlich.de,
        andrei.otcheretianski@intel.com, eliad@wizery.com,
        ath11k@lists.infradead.org
Date:   Tue, 14 Feb 2023 15:41:16 +0100
In-Reply-To: <6c2b5e49-2cdc-b506-e3c8-0a51fccc294d@quicinc.com>
References: <1394547394-3910-1-git-send-email-luciano.coelho@intel.com>
         <1394547394-3910-4-git-send-email-luciano.coelho@intel.com>
         <4de1f964-b623-2b31-c044-60cc188fc134@quicinc.com>
         <6187b1566674ba2e0d7d5413af5475688d8421b3.camel@sipsolutions.net>
         <6c2b5e49-2cdc-b506-e3c8-0a51fccc294d@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-01-10 at 15:23 +0800, Wen Gong wrote:
> On 1/9/2023 6:05 PM, Johannes Berg wrote:
> > On Mon, 2023-01-09 at 17:39 +0800, Wen Gong wrote:
> > > On 3/11/2014 10:16 PM, Luciano Coelho wrote:
> > > > ...
> > > > +int ieee80211_check_combinations(struct ieee80211_sub_if_data *sda=
ta,
> > > > +				 const struct cfg80211_chan_def *chandef,
> > > > +				 enum ieee80211_chanctx_mode chanmode,
> > > > +				 u8 radar_detect)
> ...
> > > > +
> > > > +	if (total =3D=3D 1 && !radar_detect)
> > > > +		return 0;
> > > > +
> > > should also check with cfg80211_check_combinations() when total =3D=
=3D 1 and
> > > num_different_channels > 1 ?
> > >=20
> > > When MLO is enabled, it could have 2 channels for one ieee80211_sub_i=
f_data.
> > >=20
> > Heh. You're commenting on a patch from 2014, well before MLO :-)
> >=20
> > Not sure what happens in the code now?
> >=20
> > johannes
> Yes, it is 2014. Each interface only has one channel at 2014.
> I did not hit issue for the code.
>=20
> the story is like this:
> When station interface and p2p device interface both running.
> the station connect to MLO AP which has 2 links.
> The ieee80211_link_use_channel()/ieee80211_check_combinations() call=20
> cfg80211_check_combinations()
> for the channel1 and channel2 because total=3D=3D2.
> When only station interface is running, not called for channel1/channel2=
=20
> because total=3D=3D1.
> That is the little thing I hit.
>=20

So ... I guess you found a bug? Not sure what I'm supposed to say here.
Send a fix?

johannes