Date:   Tue, 14 Feb 2023 22:04:38 +0000
From:   Conor Dooley <conor@kernel.org>
To:     Marc Bornand <dev.mbornand@systemb.ch>
Cc:     Denis Kirjanov <dkirjanov@suse.de>,
        Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless@vger.kernel.org,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Kalle Valo <kvalo@kernel.org>,
        Yohan Prod'homme <kernel@zoddo.fr>, stable@vger.kernel.org
Subject: Re: [PATCH v4] Set ssid when authenticating
Message-ID: <Y+wFdg4R1Azpssp4@spud>
References: <20230214132009.1011452-1-dev.mbornand@systemb.ch>
 <13e8e0bb-b2a2-e138-75c0-54e61a5d679e@suse.de>
 <Y+wEtf2dy8hXWYA4@opmb2>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ySt7za8gnO1TLneA"
Content-Disposition: inline
In-Reply-To: <Y+wEtf2dy8hXWYA4@opmb2>
Precedence: bulk


--ySt7za8gnO1TLneA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 14, 2023 at 10:01:35PM +0000, Marc Bornand wrote:
> On Tue, Feb 14, 2023 at 04:27:27PM +0300, Denis Kirjanov wrote:

> > On 2/14/23 16:20, Marc Bornand wrote:
> > > changes since v3:
> > > - add missing NULL check
> > > - add missing break
> > >
> > > changes since v2:
> > > - The code was tottaly rewritten based on the disscution of the
> > >   v2 patch.
> > > - the ssid is set in __cfg80211_connect_result() and only if the ssid=
 is
> > >   not already set.
> > > - Do not add an other ssid reset path since it is already done in
> > >   __cfg80211_disconnected()
> > >
> > > When a connexion was established without going through
> > > NL80211_CMD_CONNECT, the ssid was never set in the wireless_dev struc=
t.
> > > Now we set it in __cfg80211_connect_result() when it is not already s=
et.
> >
> > A couple of small nits
> >
> > >
> > > Reported-by: Yohan Prod'homme <kernel@zoddo.fr>
> > > Fixes: 7b0a0e3c3a88260b6fcb017e49f198463aa62ed1
> > Please add a test description to the fixes tag
>=20
> What do you mean by "test description" ?

s/s/x/ ;)

Fixes: 7b0a0e3c3a88 ("wifi: cfg80211: do some rework towards MLO link APIs")

Cheers,
Conor.


--ySt7za8gnO1TLneA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY+wFdgAKCRB4tDGHoIJi
0n4FAQDQZ0yLAERYxZu8ZhVFQmCORJsohZ7+pYuK15xRvYBnogD+LrI1vsI9R5vk
uFBohjgHp/LfDmVPsWpiRmlIcMJaigc=
=WUUA
-----END PGP SIGNATURE-----

--ySt7za8gnO1TLneA--