Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B3E6C636D4 for ; Wed, 15 Feb 2023 07:50:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233717AbjBOHuo (ORCPT ); Wed, 15 Feb 2023 02:50:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233631AbjBOHun (ORCPT ); Wed, 15 Feb 2023 02:50:43 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9998532CD0; Tue, 14 Feb 2023 23:50:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 40A2861A71; Wed, 15 Feb 2023 07:50:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E6AEC433EF; Wed, 15 Feb 2023 07:50:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676447438; bh=XpvbBaK4xbaNhxlwvyVb04WeG3csNvfLcdKEuWJ14Gc=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=qGLKtYOC1JidZV0q21JkS8oN2oDMbFsSJLLSQ00irZHaYfD+x/CJLL2zI11TWPQao n02MH7PytUN8YAgEmgGSclIZrUvWvyXW402uLQz65NATy640wjiqO1OaW5UbBPTk// RkEdwANKDVVbNj6pcyxKxWGvuVytPRU2YlF91SyNadoup9t5bUL/2M9Su7W5Fwy6X8 lTO5Eg/kFUxdxImILs4tnuyo651QpTbRX5ucgc9KbYl004/ZE46v10lvbxA6CPR7gB jbbMJCl3EhlWE+7yXoJfP5J7qEC++NKefFuovuO4XcDvkJ6mnb1pGsmD4PuQl2ik9h 4COw6XBFSjXNQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2 1/3] wifi: rtw88: usb: Set qsel correctly From: Kalle Valo In-Reply-To: <20230210111632.1985205-2-s.hauer@pengutronix.de> References: <20230210111632.1985205-2-s.hauer@pengutronix.de> To: Sascha Hauer Cc: linux-wireless@vger.kernel.org, Neo Jou , Hans Ulli Kroll , Ping-Ke Shih , Yan-Hsuan Chuang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Blumenstingl , kernel@pengutronix.de, Alexander Hochbaum , Da Xue , Po-Hao Huang , Andreas Henriksson , Viktor Petrenko , Sascha Hauer User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <167644743063.2758.2777342637457592464.kvalo@kernel.org> Date: Wed, 15 Feb 2023 07:50:35 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Sascha Hauer wrote: > We have to extract qsel from the skb before doing skb_push() on it, > otherwise qsel will always be 0. > > Fixes: a82dfd33d1237 ("wifi: rtw88: Add common USB chip support") > Signed-off-by: Sascha Hauer > Reviewed-by: Ping-Ke Shih 3 patches applied to wireless-next.git, thanks. 7869b834fb07 wifi: rtw88: usb: Set qsel correctly 07ce9fa6ab0e wifi: rtw88: usb: send Zero length packets if necessary 462c8db6a011 wifi: rtw88: usb: drop now unnecessary URB size check -- https://patchwork.kernel.org/project/linux-wireless/patch/20230210111632.1985205-2-s.hauer@pengutronix.de/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches